From: Jakub Jelinek <jakub@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] c++: wrong error with constexpr COMPOUND_EXPR [PR105321]
Date: Thu, 21 Apr 2022 16:22:03 +0200 [thread overview]
Message-ID: <YmFoi0Lr7/wojR7I@tucnak> (raw)
In-Reply-To: <YmFaMPqs0GrM51LF@redhat.com>
On Thu, Apr 21, 2022 at 09:20:48AM -0400, Marek Polacek via Gcc-patches wrote:
> --- a/gcc/cp/constexpr.cc
> +++ b/gcc/cp/constexpr.cc
> @@ -4566,19 +4566,18 @@ cxx_eval_bit_cast (const constexpr_ctx *ctx, tree t, bool *non_constant_p,
> static tree
> cxx_eval_logical_expression (const constexpr_ctx *ctx, tree t,
> tree bailout_value, tree continue_value,
> - bool lval,
> - bool *non_constant_p, bool *overflow_p)
> + bool, bool *non_constant_p, bool *overflow_p)
Wouldn't it be better to remove the unused lval argument from
cxx_eval_logical_expression and adjust the 2 callers?
Jakub
next prev parent reply other threads:[~2022-04-21 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 22:40 [PATCH] " Marek Polacek
2022-04-21 12:56 ` Jason Merrill
2022-04-21 13:20 ` [PATCH v2] " Marek Polacek
2022-04-21 14:15 ` Jason Merrill
2022-04-21 14:22 ` Jakub Jelinek [this message]
2022-04-21 14:25 ` Jason Merrill
2022-04-21 14:34 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmFoi0Lr7/wojR7I@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).