From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 24FDE3858405 for ; Thu, 28 Apr 2022 11:57:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24FDE3858405 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-kJYammEvNveMYW2u3F-hDw-1; Thu, 28 Apr 2022 07:57:41 -0400 X-MC-Unique: kJYammEvNveMYW2u3F-hDw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 810EE3C02B6D; Thu, 28 Apr 2022 11:57:41 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D28D5690F8; Thu, 28 Apr 2022 11:57:40 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 23SBvcMH3133402 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 13:57:38 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 23SBvb4V3133401; Thu, 28 Apr 2022 13:57:37 +0200 Date: Thu, 28 Apr 2022 13:57:37 +0200 From: Jakub Jelinek To: Jan Hubicka Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cgraph: Don't verify semantic_interposition flag for aliases [PR105399] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 11:57:46 -0000 On Thu, Apr 28, 2022 at 01:54:51PM +0200, Jan Hubicka wrote: > > --- gcc/cgraph.cc.jj 2022-04-20 09:24:12.194579146 +0200 > > +++ gcc/cgraph.cc 2022-04-27 11:53:52.102173154 +0200 > > @@ -3488,7 +3488,9 @@ cgraph_node::verify_node (void) > > "returns a pointer"); > > error_found = true; > > } > > - if (definition && externally_visible > > + if (definition > > + && externally_visible > > + && (!alias || thunk || !in_lto_p) > > The alias check seems OK to me. > Why we need thunk? Here thunk may eventually gain a gimple body and we > will be interested in its opt_for_fn flags. So if we do not set > DECL_FUNCTION_SPECIFIC_OPTIMIZATION we may get unexpected surprises > (such as blocked inlining). I've added || thunk because free_lang_data sets DECL_FUNCTION_SPECIFIC_OPTIMIZATION for thunks, the guarding condition is: if (gimple_has_body_p (decl) || (node && node->thunk)) I wasn't sure if node->alias and node->thunk can be both set or not. If they can't, I can take it out. Jakub