From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3F03D383D819 for ; Thu, 12 May 2022 12:42:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F03D383D819 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-384-hQQIqeR4PZeo8TJqv5TLrA-1; Thu, 12 May 2022 08:42:35 -0400 X-MC-Unique: hQQIqeR4PZeo8TJqv5TLrA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EE2BE3C11739; Thu, 12 May 2022 12:42:34 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD4C51541C67; Thu, 12 May 2022 12:42:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 24CCgVxw1909892 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 12 May 2022 14:42:31 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 24CCgTxM1909891; Thu, 12 May 2022 14:42:29 +0200 Date: Thu, 12 May 2022 14:42:29 +0200 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, Tom de Vries , Andrew Stubbs , Julian Brown Subject: Re: Refactor '-ldl' handling for libgomp proper and plugins Message-ID: Reply-To: Jakub Jelinek References: <87zgjnrklp.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 In-Reply-To: <87zgjnrklp.fsf@euler.schwinge.homeip.net> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 12:42:40 -0000 On Thu, May 12, 2022 at 02:39:14PM +0200, Thomas Schwinge wrote: > Hi! > > Again, no change in behavior, just refactoring, making things more > explicit, in preparation for other changes. OK to push the attached > "Refactor '-ldl' handling for libgomp proper and plugins"? > > By the way, this might also qualify as a first preparational step to > support dynamic loading schemes different from 'dl.so'/'dlopen'. ;-) > (But I'm not working on that.) Ok. > libgomp/ > * Makefile.am (libgomp_la_LIBADD): Initialize. > * plugin/configfrag.ac (DL_LIBS): New. > (PLUGIN_GCN_LIBS): Remove. > (PLUGIN_NVPTX_LIBS): Don't set in the 'PLUGIN_NVPTX_DYNAMIC' case. > * plugin/Makefrag.am (libgomp_la_LIBADD) > (libgomp_plugin_gcn_la_LIBADD): Consider '$(DL_LIBS)'. > (libgomp_plugin_nvptx_la_LIBADD) : Likewise. > * Makefile.in: Regenerate. > * config.h.in: Likewise. > * configure: Likewise. > * testsuite/Makefile.in: Likewise. Jakub