From: Jakub Jelinek <jakub@redhat.com>
To: Mohamed Atef <mohamedatef1698@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: libgompd: ADD OMPD support and global ICV functions
Date: Fri, 13 May 2022 20:27:02 +0200 [thread overview]
Message-ID: <Yn6i9tFcSSBAYM0E@tucnak> (raw)
In-Reply-To: <CAPFh8N+6MFAwzxgfBa6Wc08d-u-a5p0_Ft9KC6ucHZSDoCwnAA@mail.gmail.com>
On Fri, May 13, 2022 at 08:22:41PM +0200, Mohamed Atef wrote:
> > As I've tried to explain, this #ifdef __ELF__ doesn't belong
> > to the public header, which should contain just
> > extern void ompd_dll_locations_valid (void) __GOMPD_NOTHROW;
> > The #define should be in some internal header that is included
> > after the public one.
> >
> I will put the #define in ompd-support.h is that okay?
> And i will put ompd_bp_* labels there too.
Ok.
Jakub
next prev parent reply other threads:[~2022-05-13 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 5:15 Mohamed Atef
2022-05-10 5:21 ` Mohamed Atef
2022-05-10 5:40 ` Mohamed Atef
2022-05-13 13:14 ` Jakub Jelinek
2022-05-13 18:22 ` Mohamed Atef
2022-05-13 18:27 ` Jakub Jelinek [this message]
2022-05-13 19:19 ` Mohamed Atef
2022-05-15 14:18 ` Mohamed Atef
2022-05-15 14:36 ` Mohamed Atef
2022-05-16 17:09 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn6i9tFcSSBAYM0E@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mohamedatef1698@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).