From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by sourceware.org (Postfix) with ESMTPS id EB7183857342 for ; Thu, 5 May 2022 18:45:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB7183857342 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-548-HTaTjgNuO6CktbvR-2nO6g-1; Thu, 05 May 2022 14:45:53 -0400 X-MC-Unique: HTaTjgNuO6CktbvR-2nO6g-1 Received: by mail-qk1-f198.google.com with SMTP id u129-20020a372e87000000b0069f8a79378eso3402467qkh.5 for ; Thu, 05 May 2022 11:45:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H9a+/pCq5R8q2xMU8o5GEBV/CYFkZrSWEX7OrYdZ9+E=; b=Wo8OVY0C9v6/MIL8sdxVp3OPN1y0DP81BS7xSPKvJfMazNK/2VpUDymI490P9su/iT E6y7SkyP1/NTdWUsEvfK0vB4ZKo7l/1SHGF5JdvqE4sbVGLYZGoGXDHEi54OFL8OsKN+ hV4qNxtMRvDEG9R/IMTxkfmUQqmKxnVke6g8SfaefFQqHpXSeXeNAlefDzb8nHF3Fccy D5OAlF3OF4hmUZxKfl/l1VQXuHLYTtzyLt5IGyPSBt0j92ji+tdhs0ddKwXAZN98tj02 9SCG3wN9qAUINll8ioLBU4nrLAFJOeYG9Ao0JgZTKNy3tt/uP0UNeunYn1kq8bWS82yu yEHQ== X-Gm-Message-State: AOAM5335uEHypnfKYIgsGRmyN7wyIO/QB62e99jClZEhE2dRqSpetChP Y1qfEzYZUzK1pNgwMNomiz1JA4WtPbrCYjAaVuQQzTxEXgh8wS0j0TKHcjJrDI1NnHbfxXHn7lt EmWhEeDHCjafj5nztcg== X-Received: by 2002:a05:6214:d88:b0:45a:9a56:2028 with SMTP id e8-20020a0562140d8800b0045a9a562028mr14479224qve.18.1651776353043; Thu, 05 May 2022 11:45:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFFpDJT5ec/xg8V60Zp9KRKqAbA5rv4a+NfRFQkqbdmrTBZxIQuH0wSgItHKYNLi7LHZQwJQ== X-Received: by 2002:a05:6214:d88:b0:45a:9a56:2028 with SMTP id e8-20020a0562140d8800b0045a9a562028mr14479196qve.18.1651776352672; Thu, 05 May 2022 11:45:52 -0700 (PDT) Received: from redhat.com ([2601:184:4780:4310::f826]) by smtp.gmail.com with ESMTPSA id d5-20020ae9ef05000000b0069fc13ce1ebsm1179049qkg.28.2022.05.05.11.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 11:45:52 -0700 (PDT) Date: Thu, 5 May 2022 14:45:50 -0400 From: Marek Polacek To: jiawei Cc: gcc-patches@gcc.gnu.org, wuwei2016@iscas.ac.cn, kito.cheng@sifive.com Subject: Re: [PATCH] testsuite: Update Wconversion testcase check type. Message-ID: References: <20220505103320.3851899-1-jiawei@iscas.ac.cn> MIME-Version: 1.0 In-Reply-To: <20220505103320.3851899-1-jiawei@iscas.ac.cn> User-Agent: Mutt/2.1.5 (2021-12-30) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 18:45:56 -0000 On Thu, May 05, 2022 at 06:33:20PM +0800, jiawei wrote: > Some compiler target like arm-linux\riscv\power\s390x\xtensa-gcc handle > char as unsigned char, then there are no warnings occur and got FAIL cases. > Just change the type char into explicit signed char to keep the feature > consistency. > > gcc/testsuite/ChangeLog: > > * c-c++-common/Wconversion-1.c: Update type. Ok, and sorry for introducing this problem! > --- > gcc/testsuite/c-c++-common/Wconversion-1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/c-c++-common/Wconversion-1.c b/gcc/testsuite/c-c++-common/Wconversion-1.c > index ed65918c70f..7053f6b5dbb 100644 > --- a/gcc/testsuite/c-c++-common/Wconversion-1.c > +++ b/gcc/testsuite/c-c++-common/Wconversion-1.c > @@ -10,5 +10,5 @@ void g() > signed char sc = 300; /* { dg-warning "conversion from .int. to .signed char. changes value from .300. to .44." } */ > unsigned char uc = 300; /* { dg-warning "conversion from .int. to .unsigned char. changes value from .300. to .44." } */ > unsigned char uc2 = 300u; /* { dg-warning "conversion from .unsigned int. to .unsigned char. changes value from .300. to .44." } */ > - char c2 = (double)1.0 + 200; /* { dg-warning "overflow in conversion from .double. to .char. changes value from .2.01e\\+2. to .127." } */ > + signed char c2 = (double)1.0 + 200; /* { dg-warning "overflow in conversion from .double. to .signed char. changes value from .2.01e\\+2. to .127." } */ > } > -- > 2.25.1 > Marek