From: Marek Polacek <polacek@redhat.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@sifive.com,
wuwei2016@iscas.ac.cn, jiawei@iscas.ac.cn
Subject: Re: [PATCH] testsuite: Update Wconversion testcase check type.
Date: Tue, 10 May 2022 19:57:18 -0400 [thread overview]
Message-ID: <Ynr73mLHhnRZzrMg@redhat.com> (raw)
In-Reply-To: <mhng-61d1cd0c-0b51-46e1-9282-253b74a0eead@palmer-mbp2014>
On Tue, May 10, 2022 at 02:58:49PM -0700, Palmer Dabbelt wrote:
> On Thu, 05 May 2022 11:45:50 PDT (-0700), gcc-patches@gcc.gnu.org wrote:
> > On Thu, May 05, 2022 at 06:33:20PM +0800, jiawei wrote:
> > > Some compiler target like arm-linux\riscv\power\s390x\xtensa-gcc handle
> > > char as unsigned char, then there are no warnings occur and got FAIL cases.
> > > Just change the type char into explicit signed char to keep the feature
> > > consistency.
> > >
> > > gcc/testsuite/ChangeLog:
> > >
> > > * c-c++-common/Wconversion-1.c: Update type.
> >
> > Ok, and sorry for introducing this problem!
>
> So this is OK for trunk? Happy to commit it if you'd like, just wanted to
> make sure as I'm not seeing it on trunk.
Yes, please go ahead.
Marek
next prev parent reply other threads:[~2022-05-10 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 10:33 jiawei
2022-05-05 18:45 ` Marek Polacek
2022-05-10 21:58 ` Palmer Dabbelt
2022-05-10 23:57 ` Marek Polacek [this message]
[not found] <k49kbomqqftfj10bjs7e8o7p.1652323041358@email.android.com>
2022-05-12 4:31 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynr73mLHhnRZzrMg@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).