From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0B9763857806 for ; Tue, 17 May 2022 08:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B9763857806 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-304-e3HpzW1LMsuDSNoYEb9WpQ-1; Tue, 17 May 2022 04:21:59 -0400 X-MC-Unique: e3HpzW1LMsuDSNoYEb9WpQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1217D299E763; Tue, 17 May 2022 08:21:59 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6D421568BD9; Tue, 17 May 2022 08:21:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 24H8LuES4066677 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 17 May 2022 10:21:56 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 24H8Ltet4066676; Tue, 17 May 2022 10:21:55 +0200 Date: Tue, 17 May 2022 10:21:55 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: Gerald Pfeifer , gcc-patches Subject: Re: [wwwdocs][Patch] Add OpenMP by-GCC-version implementation status Message-ID: Reply-To: Jakub Jelinek References: <798bc8e6-567b-5ed6-e298-655948e89f5e@mentor.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 08:22:02 -0000 On Mon, May 16, 2022 at 11:42:03AM +0200, Tobias Burnus wrote: > small update (interdiff): s/s/S/ for consistency, missed one GCC 13 commit, and > improved wording of the enter/exit change. (New wording better captures the > effect; I was thinking too much of the changed spec wording not of the effective > result.) > Plus added some cross-ref hyperlinks to make finding the documentation easier: > > --- a/htdocs/projects/gomp/openmp-status.html > +++ b/htdocs/projects/gomp/openmp-status.html > @@ -25,0 +26 @@ > +
  • GOMP project page
    • > @@ -61 +61 @@ > -hint clause on the atomic constructGCC 9stub only > +hint clause on the atomic constructGCC 9Stub only > @@ -141,0 +142 @@ > +omp_get_mapped_ptr runtime routineGCC 13 > @@ -159 +159,0 @@> > -omp_get_mapped_ptr runtime routineN > @@ -195 +195 @@ > -Extended map-type handling of target enter/exit dataN > +Default map type for map clause in target enter/exit dataN > > --- a/htdocs/projects/index.html > +++ b/htdocs/projects/index.html > @@ -32,0 +33 @@ help develop GCC:

    > +
  • Implementing missing OpenMP features.
    • > > > I will incorporate the 5.2 wording change in my libgomp.texi patch. > (I think the s/stub/Stub/ change is already there and I know the > N→Y change is in the .texi.) Thanks for working on this. Please incorporate Gerald's comments and my comments about the libgomp.texi 5.2 support patch. > +

    Features added by OpenMP version

    > + I think we should have also 2.5, 3.0, 3.1 and 4.0 entries in the above list, with similar style as the OpenMP 4.5 entry. Details can be copied from the gomp/index.html page, so 2.5 supported since GCC 4.2, 3.0 supported since GCC 4.4, 3.1 supported since GCC 4.7, 4.0 supported for C/C++ since GCC 4.9 and for Fortran since GCC 4.9.1 Though, maybe a table form for the 2.5-4.5 versions would be more consistent with the rest, and just use OpenMP x.y C/C++/Fortran support or OpenMP x.y C/C++ support or OpenMP x.y Fortran support as name, for the partial/full with 2 rows like requires directive with GCC 7 row and partial in comment and GCC 11 witout a comment or with fully supported comment? Perhaps for those tables just leave the first column header blank instead of "Feature". > +Map-order clarificationsGCC? This entry I gave up on, it isn't exactly clear to me what that bullet is about and once we figure that out, we need to do some archeology on whether we support it at all and if yes, since which commit and thus since which GCC version. Otherwise LGTM. Jakub