From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 528B338312B4 for ; Tue, 24 May 2022 11:41:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 528B338312B4 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-CDSw6cqdPa6iVH4uEfPvYQ-1; Tue, 24 May 2022 07:41:46 -0400 X-MC-Unique: CDSw6cqdPa6iVH4uEfPvYQ-1 Received: by mail-qk1-f200.google.com with SMTP id bk23-20020a05620a1a1700b0067b32f93b90so13282302qkb.16 for ; Tue, 24 May 2022 04:41:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yPNpwUat+AF1mj/4deozjCR1YtenHI5rci0y+/9r2Ns=; b=UItsIdWjhvOsoaPjeZeOB2LwP3h4thb0cTrA9/iNiwV+uj7pRe9moI0mPEyZXPb52Q PD1qPV/M3x1cLBWz8rIfofeToeqAek3k+ZOs2kUoZnybssW/nTH/vyfKQqg2pBusx3QB zPMULklxvC8UzK00vhAoSmkQK0lzAwzAsg6O/k4gpv1pV0qRmzhWlqXPxorIRwTGE3E7 ThzXw5KhD1gpr6xhFe8nAJXTHpK+TKP3i6p344r8gNKhg5Vaw3ZyxAXHzT8rDjmRBRDy bwAcKYRFkIBTj7x4U53xGEmufg8AppD39jFFuSQ/Dj7SUxALqv4TZT9Lmlln9b9V3Er/ MdsA== X-Gm-Message-State: AOAM530Asd354CGNosKHHwFv/kTbLby/24TPmdknzqNSpYeFn5VrZERZ CAu8O9o7RnGCsMdKj+A0mqBoJa4dmjiOFCGml/D7X76nYqJDJK0LbN8CXcB6bW0NupZWfzaYiAR yb4MDlzfyzsfhrzTJvU2Ioanid99cYdEeI6Qo+1fkZrYFcU1ltAaPQTEr/LvM/15GSXzQ X-Received: by 2002:ac8:5b51:0:b0:2f9:4564:97ad with SMTP id n17-20020ac85b51000000b002f9456497admr1014716qtw.4.1653392505754; Tue, 24 May 2022 04:41:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTpa5i+J+z/1S1gOX+cttQo517w6tskHn958AmQU5pPlfxNflflskadopT3Q+5ATCC/krCuA== X-Received: by 2002:ac8:5b51:0:b0:2f9:4564:97ad with SMTP id n17-20020ac85b51000000b002f9456497admr1014703qtw.4.1653392505496; Tue, 24 May 2022 04:41:45 -0700 (PDT) Received: from redhat.com ([2601:184:4780:4310::9979]) by smtp.gmail.com with ESMTPSA id ew6-20020a05622a514600b002f39b99f69esm6097701qtb.56.2022.05.24.04.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 04:41:44 -0700 (PDT) Date: Tue, 24 May 2022 07:41:43 -0400 From: Marek Polacek To: GCC Patches , Jason Merrill Subject: Re: [PATCH] c++: fix ICE on invalid attributes [PR96637] Message-ID: References: <20220429141233.41897-1-polacek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220429141233.41897-1-polacek@redhat.com> User-Agent: Mutt/2.2.1 (2022-02-19) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 11:41:49 -0000 Ping. On Fri, Apr 29, 2022 at 10:12:33AM -0400, Marek Polacek via Gcc-patches wrote: > This patch fixes crashes with invalid attributes. Arguably it could > make sense to assert seen_error() too. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk = GCC 13? > > PR c++/96637 > > gcc/ChangeLog: > > * attribs.cc (decl_attributes): Check error_mark_node. > > gcc/cp/ChangeLog: > > * decl2.cc (cp_check_const_attributes): Check error_mark_node. > > gcc/testsuite/ChangeLog: > > * g++.dg/parse/error64.C: New test. > --- > gcc/attribs.cc | 3 +++ > gcc/cp/decl2.cc | 2 ++ > gcc/testsuite/g++.dg/parse/error64.C | 4 ++++ > 3 files changed, 9 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/parse/error64.C > > diff --git a/gcc/attribs.cc b/gcc/attribs.cc > index b219f878042..ff157dcf81c 100644 > --- a/gcc/attribs.cc > +++ b/gcc/attribs.cc > @@ -700,6 +700,9 @@ decl_attributes (tree *node, tree attributes, int flags, > in the same order as in the source. */ > for (tree attr = attributes; attr; attr = TREE_CHAIN (attr)) > { > + if (attr == error_mark_node) > + continue; > + > tree ns = get_attribute_namespace (attr); > tree name = get_attribute_name (attr); > tree args = TREE_VALUE (attr); > diff --git a/gcc/cp/decl2.cc b/gcc/cp/decl2.cc > index d2b29208ed5..c3ff1962a75 100644 > --- a/gcc/cp/decl2.cc > +++ b/gcc/cp/decl2.cc > @@ -1537,6 +1537,8 @@ cp_check_const_attributes (tree attributes) > /* As we implement alignas using gnu::aligned attribute and > alignas argument is a constant expression, force manifestly > constant evaluation of aligned attribute argument. */ > + if (attr == error_mark_node) > + continue; > bool manifestly_const_eval > = is_attribute_p ("aligned", get_attribute_name (attr)); > for (arg = TREE_VALUE (attr); arg && TREE_CODE (arg) == TREE_LIST; > diff --git a/gcc/testsuite/g++.dg/parse/error64.C b/gcc/testsuite/g++.dg/parse/error64.C > new file mode 100644 > index 00000000000..87848a58c27 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/parse/error64.C > @@ -0,0 +1,4 @@ > +// PR c++/96637 > +// { dg-do compile } > + > +void foo(int[] alignas[1] alignas(1)){} // { dg-error "" } > > base-commit: 9ae8b993cd362e8aea4f65580aaf1453120207f2 > -- > 2.35.1 > Marek