From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 48DFC38582B0 for ; Mon, 6 Jun 2022 13:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48DFC38582B0 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-XmTL48O8ORSQ2K7XBhiaVw-1; Mon, 06 Jun 2022 09:22:20 -0400 X-MC-Unique: XmTL48O8ORSQ2K7XBhiaVw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 78CA2811E76; Mon, 6 Jun 2022 13:22:20 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3553340EC004; Mon, 6 Jun 2022 13:22:20 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 256DMGQw184231 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 6 Jun 2022 15:22:17 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 256DMF8r184230; Mon, 6 Jun 2022 15:22:15 +0200 Date: Mon, 6 Jun 2022 15:22:15 +0200 From: Jakub Jelinek To: Chung-Lin Tang Cc: Tobias Burnus , gcc-patches , Hafiz Abid Qadeer , Andrew Stubbs Subject: Re: [PATCH, OpenMP, v2] Implement uses_allocators clause for target regions Message-ID: Reply-To: Jakub Jelinek References: <46d77e14-080c-db6c-4032-e12899c5d059@codesourcery.com> <9c0945fa-1054-095e-86ae-a9d8dd1ab625@codesourcery.com> <58c6df9a-467a-1dc3-9386-b44af5515894@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <58c6df9a-467a-1dc3-9386-b44af5515894@codesourcery.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 13:22:25 -0000 On Mon, Jun 06, 2022 at 09:19:18PM +0800, Chung-Lin Tang wrote: > On 2022/5/31 6:02 PM, Jakub Jelinek wrote: > > 5) for C++, we should handle FIELD_DECLs, but it shouldn't be hard, just > > look how it is handled for private too > > > > Jakub > > About private() for non-static members, is it really working right now? Perhaps we have a bug that we should file in bugzilla and should fix. Can you try omp parallel or omp target in the test instead? > A simple test: > > struct C { > omp_allocator_handle_t a; > void foo (void) { > #pragma omp target private (a) > a = (omp_allocator_handle_t) 0; > } > }; > > int main (void) > { > C c; > c.foo (); > return 0; > } Jakub