From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 14C153948A68 for ; Thu, 2 Jun 2022 20:33:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14C153948A68 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-yZcEkVpyNa2e8p_BScnhXA-1; Thu, 02 Jun 2022 16:33:57 -0400 X-MC-Unique: yZcEkVpyNa2e8p_BScnhXA-1 Received: by mail-qk1-f199.google.com with SMTP id o18-20020a05620a2a1200b006a0cc3d8463so4532824qkp.4 for ; Thu, 02 Jun 2022 13:33:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TssA9eyx/7TC27uqNxic63wvrFrhP7ukqvBK+Fnd5r8=; b=P1wORiEwe0qzJgGpDs8QRi9uzxo3i/O9pzGe8jyqagDsEoMAAA1GXNgBW3o1YWUcMT knF2l9cExMY/5UrFqeLYbDBXo6LMw4zFX5t3PyIUqWAG7qFF8Voy+ZEWZKtyIQErzbKv EACZG3h5tW/rD+nr01hrInDs+SNUdouojMJBklE9N2LJ1VQfX/OwqS2n3eRRr0T4jSaf ob9x0aofCnDQVxLxC4zOuQ0MTFodKMRk8wt2mCeIkX87gxhzbQHiB80t6EnhEN6hHWgK 3I9mzQ3YYQzXUsFBfO6FFNTjfcPgd9orxtqMMDkMeD8Kzy+jteTNR3tuiLr/+Y508F0R Imtg== X-Gm-Message-State: AOAM532SdxQ+Q6GbL/bA5eK6Vj0w1CixL/gGxgsal/M5eUiTm9WkgJ3B wUhId4oWnZH/PzWYop04YNQH5Bv0t5WsEDGA2phLXNgGFtcZVdR0A/txLeDtGPFdcjs93QvMQ0a l/I9zJQHLvXXuwxbZ1g== X-Received: by 2002:a0c:e808:0:b0:464:543e:4c85 with SMTP id y8-20020a0ce808000000b00464543e4c85mr16790132qvn.14.1654202036932; Thu, 02 Jun 2022 13:33:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUDwIK0ER5jgouu1LOu82bObbKwucE8r6cTjv+c8UzvWDIqbUqiNfmkzuctVRiE3IsrxMgpg== X-Received: by 2002:a0c:e808:0:b0:464:543e:4c85 with SMTP id y8-20020a0ce808000000b00464543e4c85mr16790123qvn.14.1654202036745; Thu, 02 Jun 2022 13:33:56 -0700 (PDT) Received: from redhat.com ([2601:184:4780:4310::9979]) by smtp.gmail.com with ESMTPSA id q19-20020a05620a0d9300b006a68fdc2d18sm950986qkl.130.2022.06.02.13.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 13:33:56 -0700 (PDT) Date: Thu, 2 Jun 2022 16:33:54 -0400 From: Marek Polacek To: Jason Merrill Cc: Patrick Palka , GCC Patches Subject: Re: [PATCH] c++: ICE with template NEW_EXPR [PR105803] Message-ID: References: <20220601224536.1553412-1-polacek@redhat.com> <68b3a5ff-698d-e680-6c94-b9aa5b7f3127@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.1 (2022-02-19) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 20:34:00 -0000 On Thu, Jun 02, 2022 at 04:26:27PM -0400, Jason Merrill wrote: > On 6/2/22 16:10, Marek Polacek wrote: > > index 1346a1d4c10..2bbd8785627 100644 > > --- a/gcc/cp/constexpr.cc > > +++ b/gcc/cp/constexpr.cc > > @@ -9039,10 +9039,18 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now, > > "before C++17"); > > return false; > > - case DYNAMIC_CAST_EXPR: > > - case PSEUDO_DTOR_EXPR: > > case NEW_EXPR: > > case VEC_NEW_EXPR: > > + if (cxx_dialect >= cxx20) > > + /* In C++20, new-expressions are potentially constant. */ > > + return true; > > + else if (flags & tf_error) > > + error_at (loc, "new-expression is not a constant expression " > > + "before C++20"); > > + return false; > > + > > + case DYNAMIC_CAST_EXPR: > > + case PSEUDO_DTOR_EXPR: > > case DELETE_EXPR: > > case VEC_DELETE_EXPR: > > Delete, too. Duh. Fixed: >From 2423f6548405185e256036df3d0ef3c13fd996c5 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Thu, 2 Jun 2022 15:56:18 -0400 Subject: [PATCH] c++: new-expression is potentially constant in C++20 ... so adjust p_c_e accordingly. gcc/cp/ChangeLog: * constexpr.cc (potential_constant_expression_1): Treat {,VEC_}NEW_EXPR and {,VEC_}DELETE_EXPRas potentially constant in C++20. --- gcc/cp/constexpr.cc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gcc/cp/constexpr.cc b/gcc/cp/constexpr.cc index 1346a1d4c10..684238883dc 100644 --- a/gcc/cp/constexpr.cc +++ b/gcc/cp/constexpr.cc @@ -9039,12 +9039,20 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now, "before C++17"); return false; - case DYNAMIC_CAST_EXPR: - case PSEUDO_DTOR_EXPR: case NEW_EXPR: case VEC_NEW_EXPR: case DELETE_EXPR: case VEC_DELETE_EXPR: + if (cxx_dialect >= cxx20) + /* In C++20, new-expressions are potentially constant. */ + return true; + else if (flags & tf_error) + error_at (loc, "new-expression is not a constant expression " + "before C++20"); + return false; + + case DYNAMIC_CAST_EXPR: + case PSEUDO_DTOR_EXPR: case THROW_EXPR: case OMP_PARALLEL: case OMP_TASK: base-commit: 7b98910406b5000a6429c188b0c6cc14e3140637 -- 2.36.1