From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A4F38385829B for ; Sat, 4 Jun 2022 08:32:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4F38385829B Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-322-yV4p6PugNyGh6vy_aPV-1Q-1; Sat, 04 Jun 2022 04:32:18 -0400 X-MC-Unique: yV4p6PugNyGh6vy_aPV-1Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E46EF85A5B9; Sat, 4 Jun 2022 08:32:17 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B173C15E72; Sat, 4 Jun 2022 08:32:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2548WEeg173560 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 4 Jun 2022 10:32:15 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2548WDds173559; Sat, 4 Jun 2022 10:32:13 +0200 Date: Sat, 4 Jun 2022 10:32:13 +0200 From: Jakub Jelinek To: Jan Beulich Cc: "gcc-patches@gcc.gnu.org" , bonzini@gnu.org, aoliva@gcc.gnu.org, neroden@gcc.gnu.org Subject: Re: [PATCH] configure: arrange to use appropriate objcopy Message-ID: Reply-To: Jakub Jelinek References: <0fddf82b-750a-67b8-028e-ba0a71a35cf6@suse.com> MIME-Version: 1.0 In-Reply-To: <0fddf82b-750a-67b8-028e-ba0a71a35cf6@suse.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2022 08:32:23 -0000 On Thu, Jun 02, 2022 at 05:32:10PM +0200, Jan Beulich via Gcc-patches wrote: > Using the system objcopy is wrong when other configure checks have > probed a different set of binutils (I've noticed the problem on a system > where the base objcopy can't deal with compressed debug sections). > Arrange for the matching one to be picked up, first and foremost if an > "in tree" one is available, by mirroring respective logic already > present for nm. > > gcc/ > > * Makefile.in (ORIGINAL_OBJCOPY_FOR_TARGET): New. > * configure.ac: Check for objcopy, producing > ORIGINAL_OBJCOPY_FOR_TARGET. > * configure: Update accordingly. > * exec-tool.in (ORIGINAL_OBJCOPY_FOR_TARGET): New. > Handle objcopy. This regressed Executing on host: /home/jakub/src/gcc/obj44/gcc/xgcc -B/home/jakub/src/gcc/obj44/gcc/ -fdiagnostics-plain-output -flto -g -gsplit-dwarf -c -o c_lto_pr83719_0.o /home/jakub/src/gcc/gcc/testsuite/gcc.dg/lto/pr83719_0.c (timeout = 300) spawn -ignore SIGHUP /home/jakub/src/gcc/obj44/gcc/xgcc -B/home/jakub/src/gcc/obj44/gcc/ -fdiagnostics-plain-output -flto -g -gsplit-dwarf -c -o c_lto_pr83719_0.o /home/jakub/src/gcc/gcc/testsuite/gcc.dg/lto/pr83719_0.c cc1: note: '-gsplit-dwarf' is not supported with LTO, disabling /home/jakub/src/gcc/obj44/gcc/objcopy: line 120: exec: --: invalid option exec: usage: exec [-cl] [-a name] [command [argument ...]] [redirection ...] compiler exited with status 1 FAIL: gcc.dg/lto/pr83719 c_lto_pr83719_0.o assemble, -flto -g -gsplit-dwarf for me, both on x86_64-linux and i686-linux. For some reason, I have grep OBJCOPY *gcc/Makefile gcc/Makefile:ORIGINAL_OBJCOPY_FOR_TARGET = prev-gcc/Makefile:ORIGINAL_OBJCOPY_FOR_TARGET = stage1-gcc/Makefile:ORIGINAL_OBJCOPY_FOR_TARGET = Jakub