From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 46A32383E6B3 for ; Thu, 9 Jun 2022 11:29:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46A32383E6B3 Received: by mail-pl1-x62f.google.com with SMTP id h1so19996967plf.11 for ; Thu, 09 Jun 2022 04:29:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rPbNZAvxoxinrsT0YAYNcWPM5l+kDGVkaMGJNCnII0A=; b=M/aBPP3e7ZejH0hfE85lKryHgwrdRqPxTUMGPtZvTSnPqml/MT4C9Ll5e+EWQzEKfL /R23vv/Nlg56bhnNEmGv+f7L17k9eZMLoWE8LP4FKMZh3H/JF9yoojV1DsOwZjPQgOl6 hpjhjBV1q09dqdBKR+b+81KtQwiK0K07a6TIB+ptH2MxHKjENq0Ce2wWLX847yZTocVU 8uNfVP26gLc8AgQx5m625Hium96EB7fAXvuLjPxiDdnML2KhIooTCycS/Vddx+RtLXe8 jPa7wbYfMLtaJFrecdL4tFbjovET4A8JQ+2KveT7sFfVvG1c1+r4obnbLlvV1SxMTRfL MC2Q== X-Gm-Message-State: AOAM533tSmiG433J6wyrcp5pQIMvqIWicxbFNC18ZH9tWBqdq574pNq0 diB0aFNNgsJqhiNVxwVlcJs= X-Google-Smtp-Source: ABdhPJzj3OLtQNr93xT9qh38O7aTpxsQSQS7x452dR+92+5+5c0j7ZxoPev76UXcAEKU2GaGbR/oTw== X-Received: by 2002:a17:90b:4c8a:b0:1e3:60f:58c3 with SMTP id my10-20020a17090b4c8a00b001e3060f58c3mr2985427pjb.230.1654774175082; Thu, 09 Jun 2022 04:29:35 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id oj17-20020a17090b4d9100b001e2608203d4sm18420129pjb.5.2022.06.09.04.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 04:29:34 -0700 (PDT) Date: Thu, 9 Jun 2022 20:29:32 +0900 From: Stafford Horne To: Samuel Holland Cc: gcc-patches@gcc.gnu.org, openrisc@lists.librecores.org Subject: Re: [PATCH] or1k: Add support for a little-endian target variant Message-ID: References: <20220609060357.26436-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609060357.26436-1-samuel@sholland.org> X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 11:29:38 -0000 > diff --git a/gcc/config.gcc b/gcc/config.gcc > index c5064dd37666..0c3a09dfe810 100644 > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -2866,6 +2866,11 @@ or1k*-*-*) > done > TM_MULTILIB_CONFIG=`echo $TM_MULTILIB_CONFIG | sed 's/^,//'` > > + case ${target} in > + or1k*le*-*) Should this be just or1kle*-*? > + tm_defines="${tm_defines} TARGET_LITTLE_ENDIAN_DEFAULT=1" > + ;; > + esac > case ${target} in > or1k*-*-linux*) > tm_file="${tm_file} gnu-user.h linux.h glibc-stdint.h" > diff --git a/gcc/config/or1k/or1k.opt b/gcc/config/or1k/or1k.opt > index 8a66832a99b1..497f259faae9 100644 > --- a/gcc/config/or1k/or1k.opt > +++ b/gcc/config/or1k/or1k.opt > @@ -24,6 +24,14 @@ > HeaderInclude > config/or1k/or1k-opts.h > > +mbig-endian > +Target Report RejectNegative Mask(BIG_ENDIAN) > +Use big-endian byte order. > + > +mlittle-endian > +Target Report RejectNegative InverseMask(BIG_ENDIAN, LITTLE_ENDIAN) > +Use little-endian byte order. > + We should explain what is the default int he doc's. Can you also document in: gcc/doc/invoke.texi This looks good, thank you. -Stafford