From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 267413857BBF for ; Thu, 9 Jun 2022 12:10:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 267413857BBF Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-225-AkbsvwIjNRGCCi_HulW2vw-1; Thu, 09 Jun 2022 08:10:54 -0400 X-MC-Unique: AkbsvwIjNRGCCi_HulW2vw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 429B01C1C1AC; Thu, 9 Jun 2022 12:10:54 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F18EC40D0160; Thu, 9 Jun 2022 12:10:53 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 259CApvB1627309 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 9 Jun 2022 14:10:51 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 259CApIT1627308; Thu, 9 Jun 2022 14:10:51 +0200 Date: Thu, 9 Jun 2022 14:10:50 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches Subject: Re: [Patch] OpenMP: Handle ancestor:1 with discover_declare_target Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 12:10:59 -0000 On Thu, Jun 09, 2022 at 12:47:17PM +0200, Tobias Burnus wrote: > Another minor step to getting reverse offloading to work ... > > OK for mainline? > > Tobias > > PS: As attached, this patch is a stand-alone patch, which fails > due to the requires sorry (see dg-prune-output). > With the requires patch, it should fail with the next sorry: > 'ancestor' not yet supported" > (For Fortran, it currently fails already in the FE as the > sorry prevents generating tree code. Thus, there cannot be > a Fortran check until the requires patch is in.) > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > OpenMP: Handle ancestor:1 with discover_declare_target > > gcc/ > * omp-offload.cc (omp_discover_declare_target_tgt_fn_r, > omp_discover_declare_target_fn_r): Don't walk reverse-offload > target regions. > > gcc/testsuite/ > * c-c++-common/gomp/reverse-offload-1.c: New. LGTM, thanks. Jakub