From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 06BC23857BA3 for ; Fri, 10 Jun 2022 19:23:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 06BC23857BA3 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-457-XbN8PZAYNdOlpk0pQvwXcw-1; Fri, 10 Jun 2022 15:23:34 -0400 X-MC-Unique: XbN8PZAYNdOlpk0pQvwXcw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1B18185A79C; Fri, 10 Jun 2022 19:23:33 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 835B81415100; Fri, 10 Jun 2022 19:23:33 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 25AJNUV93461132 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 10 Jun 2022 21:23:30 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 25AJNUHB3461131; Fri, 10 Jun 2022 21:23:30 +0200 Date: Fri, 10 Jun 2022 21:23:29 +0200 From: Jakub Jelinek To: Thomas Schwinge , gcc-patches@gcc.gnu.org Subject: Re: [committed] openmp: Add support for HBW or large capacity or interleaved memory through the libmemkind.so library Message-ID: Reply-To: Jakub Jelinek References: <87a6am5epb.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 19:23:39 -0000 On Thu, Jun 09, 2022 at 01:57:52PM +0200, Jakub Jelinek via Gcc-patches wrote: > On Thu, Jun 09, 2022 at 12:11:28PM +0200, Thomas Schwinge wrote: > > On 2022-06-09T10:19:03+0200, Jakub Jelinek via Gcc-patches wrote: > > > This patch adds support for dlopening libmemkind.so > > > > Instead of 'dlopen'ing literally 'libmemkind.so': > > > > > --- libgomp/allocator.c.jj 2022-06-08 08:21:03.099446883 +0200 > > > +++ libgomp/allocator.c 2022-06-08 13:41:45.647133610 +0200 > > > > > + void *handle = dlopen ("libmemkind.so", RTLD_LAZY); > > > > ..., shouldn't this instead 'dlopen' 'libmemkind.so.0'? At least for > > Debian/Ubuntu, the latter ('libmemkind.so.0') is shipped in the "library" > > package: > > I agree and I've actually noticed it too right before committing, but I thought > I'll investigate and tweak incrementally because "libmemkind.so" > is what I've actually tested (it is what llvm libomp uses). And here is what I've committed after bootstrapping/regtesting it on x86_64-linux and i686-linux. 2022-06-10 Jakub Jelinek * allocator.c (gomp_init_memkind): Call dlopen with "libmemkind.so.0" rather than "libmemkind.so". --- libgomp/allocator.c.jj 2022-06-09 10:14:33.470973961 +0200 +++ libgomp/allocator.c 2022-06-09 14:05:33.665803457 +0200 @@ -99,7 +99,7 @@ static pthread_once_t memkind_data_once static void gomp_init_memkind (void) { - void *handle = dlopen ("libmemkind.so", RTLD_LAZY); + void *handle = dlopen ("libmemkind.so.0", RTLD_LAZY); struct gomp_memkind_data *data; int i; static const char *kinds[] = { Jakub