From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6B9083858430 for ; Mon, 13 Jun 2022 20:03:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B9083858430 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-2jvc_EUJPMiDJEWv50BD9A-1; Mon, 13 Jun 2022 16:03:20 -0400 X-MC-Unique: 2jvc_EUJPMiDJEWv50BD9A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF93329ABA2E for ; Mon, 13 Jun 2022 20:03:19 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7ABA52026D64; Mon, 13 Jun 2022 20:03:19 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 25DK3HsW3472953 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 13 Jun 2022 22:03:17 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 25DK3G3N3472952; Mon, 13 Jun 2022 22:03:16 +0200 Date: Mon, 13 Jun 2022 22:03:16 +0200 From: Jakub Jelinek To: Jason Merrill Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH RFA] ubsan: -Wreturn-type and ubsan trap-on-error Message-ID: Reply-To: Jakub Jelinek References: <20220613193823.3233868-1-jason@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220613193823.3233868-1-jason@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 20:03:22 -0000 On Mon, Jun 13, 2022 at 03:38:23PM -0400, Jason Merrill via Gcc-patches wrote: > I noticed that -fsanitize=undefined -fsanitize-undefined-trap-on-error was > omitting the usual -Wreturn-type warning for control flowing off the end of > a function. This was because the warning code was looking for calls either > to __builtin_unreachable or the UBSan function, but these flags produce a > call to __builtin_trap instead. > > Tested x86_64-pc-linux-gnu, OK for trunk? > > gcc/c-family/ChangeLog: > > * c-ubsan.cc (ubsan_instrument_return): Use BUILTINS_LOCATION. > > gcc/ChangeLog: > > * tree-cfg.cc (pass_warn_function_return::execute): Also check > BUILT_IN_TRAP. > > gcc/testsuite/ChangeLog: > > * g++.dg/ubsan/return-8.C: New test. LGTM. Jakub