From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B6A443842AF9 for ; Thu, 30 Jun 2022 13:21:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6A443842AF9 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-531-gE6sAKPtPGiNsr5WH0kvLA-1; Thu, 30 Jun 2022 09:21:32 -0400 X-MC-Unique: gE6sAKPtPGiNsr5WH0kvLA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E432C86F151; Thu, 30 Jun 2022 13:21:18 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A510340CF8EF; Thu, 30 Jun 2022 13:21:18 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 25UDLGPv4007505 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 30 Jun 2022 15:21:16 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 25UDLFLY4007504; Thu, 30 Jun 2022 15:21:15 +0200 Date: Thu, 30 Jun 2022 15:21:15 +0200 From: Jakub Jelinek To: Marcel Vollweiler , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] OpenMP, libgomp: Environment variable syntax extension. Message-ID: Reply-To: Jakub Jelinek References: <392c847d-e798-2be3-a808-6888de6c90cd@codesourcery.com> <73621930-22ce-c3f1-61e0-f15683f8b281@codesourcery.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 13:21:37 -0000 On Thu, Jun 30, 2022 at 01:40:24PM +0200, Jakub Jelinek via Gcc-patches wrote: > > +/* The initial ICV values for the host, which are configured with environment > > + variables without a suffix, e.g. OMP_NUM_TEAMS. */ > > +struct gomp_initial_icvs gomp_initial_icvs_none; > > + > > +/* Initial ICV values that were configured for the host and for all devices by > > + using environment variables like OMP_NUM_TEAMS_ALL. */ > > +struct gomp_initial_icvs gomp_initial_icvs_all; > > + > > +/* Initial ICV values that were configured only for devices (not for the host) > > + by using environment variables like OMP_NUM_TEAMS_DEV. */ > > +struct gomp_initial_icvs gomp_initial_icvs_dev; > > As I said last time, I don't like allocating these > all the time in the data section of libgomp when at least for a few upcoming > years, most users will never use those suffixes. > Can't *_DEV and *_ALL go into the gomp_initial_icv_dev_list > chain too, perhaps Sorry, forgot to finish sentence, I meant perhaps with dev_num of some magic negative constants, and ensure that the all entry goes e.g. first in the list, then dev and then the rest, so when filling up say what values to copy to some device, it would start with the defaults, then if all is present overwrite from selected all vars, then if non-host and dev is present, overwrite from selected dev vars and finally overwrite from selected specific device vars. Jakub