From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 416A73858280 for ; Tue, 5 Jul 2022 14:58:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 416A73858280 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-_-7FbGpDNLm0kEavQ7Vj5g-1; Tue, 05 Jul 2022 10:58:43 -0400 X-MC-Unique: _-7FbGpDNLm0kEavQ7Vj5g-1 Received: by mail-qt1-f199.google.com with SMTP id fz24-20020a05622a5a9800b0031d5de96774so5153872qtb.7 for ; Tue, 05 Jul 2022 07:58:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oqtTSCaW+0S93xEk4ZOb4Vwn2RM5oO0lQpmlc3RcoTc=; b=NHpmJ1vEAi3Q2hEa9WF/6NKpvYcezgauJbvKZ6JalIKuEjDSub7KONWkp7vQpFx3e4 KuoYc4fPd1yhDnrh6ebFme97A+iHl1aZlU76TX9XYPsFxBQk8UAxhz3Ym+jfKOqh55LS y3vQ7Vzr5KXujoIea9/p7HOG12fH/Zbi6aeVyS0i9k21T338ZeWYMGo+3UMq+96P0ftt 30ezkz2FpA16JLm0aqMKN2XJqw1jF1odzabStUuzD+nJ0YZeUoHJS1SjPgbItrN/SQnw p773ezrjfo+oz+Moywm9+KXRZVNVz/TvgX1tVagDALEHRvFW0NHqiPhDw5K7SZs4OpWq xOOA== X-Gm-Message-State: AJIora/RX9vlKHWqTMrJ208Hf/RZa+TJrqrFTwYL7UIXDPtNIS3pBR/L hgvctBP07l3QZjujsQO80qTHS818Dzzr/HKv7ib+hAkuMPmlmDJ5qgOVhA2bpsppKKQ7DLgCwff OK/Cn0fLUGqCT2WsCbQ== X-Received: by 2002:ae9:e8ce:0:b0:6af:6dba:b772 with SMTP id a197-20020ae9e8ce000000b006af6dbab772mr22894184qkg.405.1657033122524; Tue, 05 Jul 2022 07:58:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vaUoxqe6aAeS+pApTT+NpZ363Pe/Etg9n+Khgyz3AlxoqMGC1P9rTOFPklLn3wnKJRGoqr1A== X-Received: by 2002:ae9:e8ce:0:b0:6af:6dba:b772 with SMTP id a197-20020ae9e8ce000000b006af6dbab772mr22894170qkg.405.1657033122240; Tue, 05 Jul 2022 07:58:42 -0700 (PDT) Received: from redhat.com ([2601:184:4780:4310::fd37]) by smtp.gmail.com with ESMTPSA id u12-20020ac8050c000000b003051ea4e7f6sm21831982qtg.48.2022.07.05.07.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 07:58:41 -0700 (PDT) Date: Tue, 5 Jul 2022 10:58:40 -0400 From: Marek Polacek To: Jonathan Wakely Cc: gcc Patches Subject: Re: [PATCH] c-family: Add names to diagnostics for known headers Message-ID: References: <20220630151142.1242987-1-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 14:58:45 -0000 On Mon, Jul 04, 2022 at 05:25:42PM +0100, Jonathan Wakely wrote: > On Thu, 30 Jun 2022 at 16:15, Marek Polacek wrote: > > > > On Thu, Jun 30, 2022 at 04:11:42PM +0100, Jonathan Wakely via Gcc-patches wrote: > > > I recently changed to no longer include an unnecessary header, > > > which meant it no longer includes , which means it no longer > > > includes . This resulted in some build failures: > > > https://issues.apache.org/jira/browse/LUCENE-10630 > > > https://github.com/openSUSE/libzypp/pull/405 > > > > > > And that revealed that we don't suggest the right header for those > > > functions. Fixed like so. > > > > > > Tested x86_64-linux. OK for trunk? > > > > Ok, thanks. > > OK for gcc-12 too? I already backported the include streamlining for > that causes several packages to get errors for missing > , so it makes sense to also backport these improved > diagnostics. Since the patch isn't adding any new diagnostics that previously wasn't there, I think it's OK as well, thanks. Marek