From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 1546B3858D37 for ; Thu, 14 Jul 2022 21:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1546B3858D37 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26ELarie024304; Thu, 14 Jul 2022 21:50:02 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hatuggk6r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jul 2022 21:50:01 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 26ELasmY024507; Thu, 14 Jul 2022 21:50:00 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hatuggk6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jul 2022 21:50:00 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26ELKrpM026423; Thu, 14 Jul 2022 21:49:59 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma03dal.us.ibm.com with ESMTP id 3ha4qy0mq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jul 2022 21:49:59 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26ELnwHq000608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Jul 2022 21:49:58 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C8E66B2064; Thu, 14 Jul 2022 21:49:58 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82686B205F; Thu, 14 Jul 2022 21:49:58 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.160.177.21]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTPS; Thu, 14 Jul 2022 21:49:58 +0000 (GMT) Date: Thu, 14 Jul 2022 17:49:57 -0400 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , gcc-patches@gcc.gnu.org, "Kewen.Lin" , David Edelsohn , Peter Bergner , Will Schmidt Subject: Re: [GCC 12 backport] Disable generating load/store vector pairs for block copies. Message-ID: Mail-Followup-To: Michael Meissner , Segher Boessenkool , gcc-patches@gcc.gnu.org, "Kewen.Lin" , David Edelsohn , Peter Bergner , Will Schmidt References: <20220714211214.GW25951@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714211214.GW25951@gate.crashing.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Tk18l80hixDdnDzOFHH1k0-gI24XIWO2 X-Proofpoint-ORIG-GUID: v69Cf86GC3MgYAjRZetjAtVolfYQrawc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-14_17,2022-07-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207140094 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 21:50:05 -0000 On Thu, Jul 14, 2022 at 04:12:14PM -0500, Segher Boessenkool wrote: > On Thu, Jul 14, 2022 at 11:20:56AM -0400, Michael Meissner wrote: > > I have applied the patch to GCC 12. > > > > | From 22736f3d0d4fb8ce4afb3230023f8accdb03a623 Mon Sep 17 00:00:00 2001 > > | From: Michael Meissner > > | Date: Thu, 14 Jul 2022 11:16:08 -0400 > > | Subject: [PATCH] [BACKPORT] Disable generating load/store vector pairs for block copies. > > > > Testing has found that using load and store vector pair for block copies > > can result in a slow down on power10. This patch disables using the > > vector pair instructions for block copies if we are tuning for power10. > > > > 2022-06-11 Michael Meissner > > > > gcc/ > > > > * config/rs6000/rs6000.cc (rs6000_option_override_internal): Do > > not generate block copies with vector pair instructions if we are > > tuning for power10. Back port from master branch. > > You never posted the trunk version of this, so that never was approved > either. I did post the trunk version on June 10th, and your only comment was fix the commit message, which I thought I did in the commit. > > +++ b/gcc/config/rs6000/rs6000.cc > > @@ -4151,7 +4151,10 @@ rs6000_option_override_internal (bool global_init_p) > > > > if (!(rs6000_isa_flags_explicit & OPTION_MASK_BLOCK_OPS_VECTOR_PAIR)) > > { > > - if (TARGET_MMA && TARGET_EFFICIENT_UNALIGNED_VSX) > > + /* Do not generate lxvp and stxvp on power10 since there are some > > + performance issues. */ > > + if (TARGET_MMA && TARGET_EFFICIENT_UNALIGNED_VSX > > + && rs6000_tune != PROCESSOR_POWER10) > > rs6000_isa_flags |= OPTION_MASK_BLOCK_OPS_VECTOR_PAIR; > > else > > rs6000_isa_flags &= ~OPTION_MASK_BLOCK_OPS_VECTOR_PAIR; > > The TARGET_MMA in that should not be there. Please fix that (that > probably needs more changes). All of the movoo and movxo support require TARGET_MMA as does the code in rs6000-string.cc that could possibly generate load/store vector pair. To remove the check here would mean also fixing all of the vector load and store pairs in mma.md. > This statement does the opposite of what the comment says. > > Please fix this. On trunk, first. -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meissner@linux.ibm.com