From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1F93B3857B83 for ; Fri, 29 Jul 2022 10:34:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F93B3857B83 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-166-VOtZFdOpMa6ycfrqv4sGxg-1; Fri, 29 Jul 2022 06:34:10 -0400 X-MC-Unique: VOtZFdOpMa6ycfrqv4sGxg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A1A431C08973; Fri, 29 Jul 2022 10:34:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61B65492C3B; Fri, 29 Jul 2022 10:34:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 26TAY7rX234830 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 29 Jul 2022 12:34:08 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 26TAY6Dt234829; Fri, 29 Jul 2022 12:34:06 +0200 Date: Fri, 29 Jul 2022 12:34:06 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches@gcc.gnu.org Subject: Re: [Patch] Add libgomp.c-c++-common/pr106449-2.c (was: [committed] openmp: Fix up handling of non-rectangular simd loops with pointer type iterators [PR106449]) Message-ID: Reply-To: Jakub Jelinek References: <21e39473-5bcc-02a0-fc64-564e0a606ac2@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <21e39473-5bcc-02a0-fc64-564e0a606ac2@codesourcery.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 10:34:14 -0000 On Fri, Jul 29, 2022 at 11:48:08AM +0200, Tobias Burnus wrote: > On 29.07.22 10:03, Jakub Jelinek wrote: > > There were 2 issues visible on this new testcase, one that we didn't have > > special POINTER_TYPE_P handling in a few spots of expand_omp_simd ... > > The other issue was that we put n2 expression directly into a > > comparison in a condition and regimplified that, for the &a[512] case that > > and with gimplification being destructed that unfortunately meant modification > > of original fd->loops[?].n2. Fixed by unsharing the expression. > > I created a testcase for the non-simd case ā€“ and due to messing up, it failed; > hence, I filled PR middle-end/106467. After fixing the testcase, it passes. > (ā†’ closed PR as invalid). > > However, given that the testcase now exists, I think it makes sense to add it :-) > > Changes compared to the simd testcase: replaced '(parallel for) simd' by 'for', > removed 'linear', used now 'b' and 'c' instead of storing both ptrs in 'b'. > > Side remark: Before GCC 12, GCC complained about "q = p + n" with > "error: initializer expression refers to iteration variable ā€˜pā€™". > > OK for mainline? Ok, thanks. Jakub