From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hubicka@kam.mff.cuni.cz>
Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16])
 by sourceware.org (Postfix) with ESMTPS id 1E2B23858C50
 for <gcc-patches@gcc.gnu.org>; Tue,  2 Aug 2022 16:27:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E2B23858C50
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)
 id 8B1E2284ABE; Tue,  2 Aug 2022 18:27:01 +0200 (CEST)
Date: Tue, 2 Aug 2022 18:27:01 +0200
From: Jan Hubicka <hubicka@ucw.cz>
To: Martin =?iso-8859-2?Q?Li=B9ka?= <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org, Martin Jambor <mjambor@suse.cz>
Subject: Re: [PATCH] IPA: reduce what we dump in normal mode
Message-ID: <YulQVa2DAdEm0Wo1@kam.mff.cuni.cz>
References: <6a2508ac-9673-c759-c0a1-bd78a67105f6@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6a2508ac-9673-c759-c0a1-bd78a67105f6@suse.cz>
X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2022 16:27:04 -0000

> gcc/ChangeLog:
> 
> 	* profile.cc (compute_branch_probabilities): Dump details only
> 	if TDF_DETAILS.
> 	* symtab.cc (symtab_node::dump_base): Do not dump pointer unless
> 	TDF_ADDRESS is used, it makes comparison harder.
> ---
>  gcc/profile.cc | 2 +-
>  gcc/symtab.cc  | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/profile.cc b/gcc/profile.cc
> index 08af512cbca..92de821b8bb 100644
> --- a/gcc/profile.cc
> +++ b/gcc/profile.cc
> @@ -766,7 +766,7 @@ compute_branch_probabilities (unsigned cfg_checksum, unsigned lineno_checksum)
>  	      sum2 += freq2;
>  	    }
>  	}
> -      if (dump_file)
> +      if (dump_file && (dump_flags & TDF_DETAILS))
If you disable dumping, you can also disable the collection of stats
which is guarded by if (dump_file) as well.  Otherwise the patch is OK.
>  	{
>  	  double nsum1 = 0, nsum2 = 0;
>  	  stats.qsort (cmp_stats);
> diff --git a/gcc/symtab.cc b/gcc/symtab.cc
> index 8670337416e..f2d96c0268b 100644
> --- a/gcc/symtab.cc
> +++ b/gcc/symtab.cc
> @@ -894,7 +894,8 @@ symtab_node::dump_base (FILE *f)
>    };
>  
>    fprintf (f, "%s (%s)", dump_asm_name (), name ());
> -  dump_addr (f, " @", (void *)this);
> +  if (dump_flags & TDF_ADDRESS)
> +    dump_addr (f, " @", (void *)this);
>    fprintf (f, "\n  Type: %s", symtab_type_names[type]);
>  
>    if (definition)
> -- 
> 2.37.1
>