Re: [Patch] mkoffload: Cleanup temporary omp_requires_file

[Jakub Jelinek <jakub@redhat.com>]

On Fri, Aug 19, 2022 at 04:01:10PM +0200, Tobias Burnus wrote:
> Rather obvious, once found. I forgot to add some cleanup, cluttering
> /tmp with ".mkoffload.omp_requires".
> 
> The same issue exists for GCN also for ".mkoffload.dbg"
> 
> OK for mainline? – For the dbg issue, OK also for GCC 11 and 12 backport?
> 
> Follow-up to the 'OpenMP: Move omp requires checks to libgomp" commit
> https://gcc.gnu.org/r13-1458-g683f11843974f0bdf42f79cdcbb0c2b43c7b81b0
> 
> For GCN, the issues exists since
> https://gcc.gnu.org/r11-6683-g505caa7295b93ecdec8ac9b31595eb34dbd48c9f
> 
> Tobias
> 
> PS: In case you wonder why it is also added with -save-temps: The
> internally called maybe_unlink removed the file, unless -save-temps. For
> the latter, with verbose flag, it also shows them as '[Leaving %s]'.
> 
> PPS: If you see some ...target.o files in /tmp, that's because of
> https://gcc.gnu.org/PR106686
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

> mkoffload: Cleanup temporary omp_requires_file
> 
> The file (suffix ".mkoffload.omp_requires") used to save the 'omp requires'
> data has to be passed to maybe_unlink for cleanup or -v -save-temps stderr
> diagnostic. That was missed before. - For GCN, the same has to be done for
> the files with suffix ".mkoffload.dbg.o".
> 
> gcc/ChangeLog:
> 
> 	* config/gcn/mkoffload.cc (main): Add omp_requires_file and dbgobj to
> 	files_to_cleanup.
> 	* config/i386/intelmic-mkoffload.cc (prepare_target_image): Add
> 	omp_requires_file to temp_files.
> 	* config/nvptx/mkoffload.cc (omp_requires_file): New global static var.
> 	(main): Remove local omp_requires_file var.
> 	(tool_cleanup): Handle omp_requires_file.

Ok, thanks.

	Jakub