From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 528B4385843A for ; Wed, 10 Aug 2022 13:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 528B4385843A Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-6xPzLLMOM-CTZTNvaVsoFQ-1; Wed, 10 Aug 2022 09:59:40 -0400 X-MC-Unique: 6xPzLLMOM-CTZTNvaVsoFQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DEA9F18F0241; Wed, 10 Aug 2022 13:59:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 777C69457F; Wed, 10 Aug 2022 13:59:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 27ADxZkf2119501 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 10 Aug 2022 15:59:36 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 27ADxYLW2119500; Wed, 10 Aug 2022 15:59:34 +0200 Date: Wed, 10 Aug 2022 15:59:34 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/106513 - fix mistake in bswap symbolic number shifts Message-ID: Reply-To: Jakub Jelinek References: <20220810134711.51ABC13AB3@imap2.suse-dmz.suse.de> MIME-Version: 1.0 In-Reply-To: <20220810134711.51ABC13AB3@imap2.suse-dmz.suse.de> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 13:59:45 -0000 On Wed, Aug 10, 2022 at 03:47:10PM +0200, Richard Biener via Gcc-patches wrote: > This fixes a mistake in typing a local variable in the symbolic > shift routine. > > Bootstrap & regtest pending on x86_64-unknown-linux-gnu. > > PR tree-optimization/106513 > * gimple-ssa-store-merging.cc (do_shift_rotate): Use uint64_t > for head_marker. Ok. > > * gcc.dg/torture/pr106513.c: New testcase. > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/torture/pr106513.c > @@ -0,0 +1,26 @@ > +/* { dg-do run } */ > + > +typedef __INT64_TYPE__ int64_t; > + > +__attribute__((noinline)) int64_t > +swap64 (int64_t n) > +{ > + return (((n & (((int64_t) 0xff) )) << 56) | > + ((n & (((int64_t) 0xff) << 8)) << 40) | > + ((n & (((int64_t) 0xff) << 16)) << 24) | > + ((n & (((int64_t) 0xff) << 24)) << 8) | > + ((n & (((int64_t) 0xff) << 32)) >> 8) | > + ((n & (((int64_t) 0xff) << 40)) >> 24) | > + ((n & (((int64_t) 0xff) << 48)) >> 40) | > + ((n & ((int64_t)(0xffull << 56))) >> 56)); > +} > + > +int main (void) > +{ > + volatile int64_t n = 0x8000000000000000l; > + > + if (swap64(n) != 0xffffffffffffff80l) > + __builtin_abort (); Please use ll instead of l in both cases above. Perhaps -0x80ll would be simpler... Jakub