From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3F9393858D1E for ; Mon, 15 Aug 2022 16:23:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F9393858D1E Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-125-zeF1UIBGMq2Q9wj6_d8G1Q-1; Mon, 15 Aug 2022 12:23:16 -0400 X-MC-Unique: zeF1UIBGMq2Q9wj6_d8G1Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D6763C0D842; Mon, 15 Aug 2022 16:23:16 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA736945D7; Mon, 15 Aug 2022 16:23:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 27FGNCrE1246815 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 15 Aug 2022 18:23:13 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 27FGNBbk1246814; Mon, 15 Aug 2022 18:23:11 +0200 Date: Mon, 15 Aug 2022 18:23:10 +0200 From: Jakub Jelinek To: FX Cc: Richard Biener , "Joseph S. Myers" , Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Implement __builtin_issignaling Message-ID: Reply-To: Jakub Jelinek References: <27AEC2DE-7798-445E-8FF0-A58D2424F962@gmail.com> MIME-Version: 1.0 In-Reply-To: <27AEC2DE-7798-445E-8FF0-A58D2424F962@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 16:23:23 -0000 On Mon, Aug 15, 2022 at 06:14:22PM +0200, FX wrote: > Thank you for taking this on (this patch and the Fortran ones), it is really appreciated and will improve gfortran's IEEE conformance. > > - "Implement __builtin_issignaling”: is approved for the tiny Fortran part > - "libgfortran: Use __builtin_issignaling in libgfortran”: was approved by Thomas Thanks. > - I will have to look at the next two patches (ieee_value and ieee_class) in the next few days. I think we can make adjustments to the runtime library as well. I think we can, but we need to make it in an ABI compatible way until libgfortran bumps soname. That is why I haven't used _gfortrani_whatever as name etc. > > Related: there are several tests in our testsuite that have { dg-require-effective-target issignaling } > This is checked by check_effective_target_issignaling in gcc/testsuite/lib/target-supports.exp, and probes the support for the issignaling macro in . I think it would make sense to adjust those tests to run on a wider range of targets, using the new built-in. We could replace it with some other effective target that would test if the target supports sNaNs (or perhaps just NaNs might be enough). Jakub