From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, OpenMP, C++] Allow classes with static members to be mappable
Date: Wed, 17 Aug 2022 14:13:28 +0200 [thread overview]
Message-ID: <YvzbaFQ5/tRQfa8m@tucnak> (raw)
In-Reply-To: <4e5632ec-d25a-445e-2c74-5b54a8d145ea@codesourcery.com>
On Wed, Jul 27, 2022 at 01:45:30PM +0200, Tobias Burnus wrote:
> OpenMP/C++: Allow classes with static members to be mappable
>
> As this is the last lang-specific user of the omp_mappable_type hook,
> the hook is removed, keeping only a generic omp_mappable_type for
> incomplete types (or error_node).
>
> gcc/c/ChangeLog:
>
> * c-decl.cc (c_decl_attributes, finish_decl): Call omp_mappable_type
> instead of removed langhook.
> * c-typeck.cc (c_finish_omp_clauses): Likewise.
>
> gcc/cp/ChangeLog:
>
> * cp-objcp-common.h (LANG_HOOKS_OMP_MAPPABLE_TYPE): Remove.
> * cp-tree.h (cp_omp_mappable_type, cp_omp_emit_unmappable_type_notes):
> Remove.
> * decl2.cc (cp_omp_mappable_type_1, cp_omp_mappable_type,
> cp_omp_emit_unmappable_type_notes): Remove.
> (cplus_decl_attributes): Call omp_mappable_type instead of
> removed langhook.
> * decl.cc (cp_finish_decl): Likewise; call cxx_incomplete_type_inform
> in lieu of cp_omp_emit_unmappable_type_notes.
> * semantics.cc (finish_omp_clauses): Likewise.
>
> gcc/ChangeLog:
>
> * gimplify.cc (omp_notice_variable): Call omp_mappable_type
> instead of removed langhook.
> * omp-general.h (omp_mappable_type): New prototype.
> * omp-general.cc (omp_mappable_type): New; moved from ...
> * langhooks.cc (lhd_omp_mappable_type): ... here.
> * langhooks-def.h (lhd_omp_mappable_type,
> LANG_HOOKS_OMP_MAPPABLE_TYPE): Remove.
> (LANG_HOOKS_FOR_TYPES_INITIALIZER): Remote the latter.
> * langhooks.h (struct lang_hooks_for_types): Remove
> omp_mappable_type.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/gomp/unmappable-1.C: Remove dg-error; remove dg-note no
> longer shown as TYPE_MAIN_DECL is NULL.
> * c-c++-common/gomp/map-incomplete-type.c: New test.
>
> Co-authored-by: Chung-Lin Tang <cltang@codesourcery.com>
Ok, thanks.
Jakub
prev parent reply other threads:[~2022-08-17 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 11:04 Chung-Lin Tang
2022-05-05 9:12 ` Jakub Jelinek
2022-07-27 11:45 ` Tobias Burnus
2022-08-17 12:13 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvzbaFQ5/tRQfa8m@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).