From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4850D3858C33 for ; Wed, 17 Aug 2022 12:17:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4850D3858C33 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-547-W_9n7O3YPnyB9yKbE3D0UA-1; Wed, 17 Aug 2022 08:17:24 -0400 X-MC-Unique: W_9n7O3YPnyB9yKbE3D0UA-1 Received: by mail-qv1-f71.google.com with SMTP id op9-20020a056214458900b00475a72eeb4dso6034098qvb.11 for ; Wed, 17 Aug 2022 05:17:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=2BbgwEhlqmojNhVvBV2hocGGGUKqOjxZzeOzqlt90vI=; b=HZKNEJLTrhP7zhJ2uQ9li/SC3HpiUphYJaNNHuVfL+Q14jqe4FaqHYRbDdQyb5io+x ytegK9Yn6kB+IMjNNAlWY5woCjanmYHk194Ac3KEQIDtQf9m+vxChOscq4pDLbql2Zrp AnGyL0F1hTDwwCywROW6rd8MwVTz7As1+reMEoQSqeGPgZUM9hcp8/xJ/hzEYbNuogRE AZM/qH+nwdh/alGm6rmQgIwUAxoENLPI83NpWVeAeDWOoS3CBFTbXxMASsbDGwJBWqo2 AvUPMpDGGf5WBb7wBh/MIWEnkZJALT4FBGLu5XgCVAz3ZOMFsBR0leDb/8JAOGvZt/H0 kkdw== X-Gm-Message-State: ACgBeo31mZ/zdR26PgWeGHN7+j0BtUSk73eoR6xKF8HFpSuB9MeiABQJ i1g7B1m9XTNVUELIwcHfHP6b34KwMFpsHfS+dtK+jWARUXFOuT44RQlY9N3YrFkvoriEHTSAZZy p45WYlvj3tm4Xu4Tu5w== X-Received: by 2002:a05:622a:1206:b0:344:56bc:a443 with SMTP id y6-20020a05622a120600b0034456bca443mr13855883qtx.35.1660738643922; Wed, 17 Aug 2022 05:17:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR6+6t8tYrBzcFGjv9HeXkN9xBSxuiTJBcJUB6lmfDqwas297g9Ew01JClI0jF1vCLC5ZiED2w== X-Received: by 2002:a05:622a:1206:b0:344:56bc:a443 with SMTP id y6-20020a05622a120600b0034456bca443mr13855872qtx.35.1660738643716; Wed, 17 Aug 2022 05:17:23 -0700 (PDT) Received: from redhat.com ([2601:184:4780:4310::e531]) by smtp.gmail.com with ESMTPSA id x2-20020ac87302000000b00342b7e4241fsm12257846qto.77.2022.08.17.05.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:17:23 -0700 (PDT) Date: Wed, 17 Aug 2022 08:17:21 -0400 From: Marek Polacek To: Ulrich Drepper Cc: gcc-patches@gcc.gnu.org Subject: Re: add more C++ name hints Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 12:17:27 -0000 On Fri, Aug 05, 2022 at 09:35:33PM +0200, Ulrich Drepper via Gcc-patches wrote: > How about adding a few more names from the std namespace to get appropriate > hints? This patch compiles and the appropriate messages are printed. Is > there a problem with just adding more or even at some point all the symbols > of the standard library? IMHO if the table in get_std_name_hint gets too big, we should probably see if we can replace the O(n) search with something more efficient. > gcc/ChangeLog: > > * cp/name-lookup.cc (get_std_name_hint): Add more symbols from the > , , and headers. Please drop the "cp/" prefix here. Patch LGTM, but I can't approve. Thanks and sorry for the delay, Marek