From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0599D3858D1E for ; Wed, 17 Aug 2022 13:31:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0599D3858D1E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-n-PU0n1xO0e9LhIz64HUXg-1; Wed, 17 Aug 2022 09:31:33 -0400 X-MC-Unique: n-PU0n1xO0e9LhIz64HUXg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 495DA85A586; Wed, 17 Aug 2022 13:31:33 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AFA814582E0; Wed, 17 Aug 2022 13:31:32 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 27HDVU5j3133642 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 17 Aug 2022 15:31:30 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 27HDVTTn3133641; Wed, 17 Aug 2022 15:31:29 +0200 Date: Wed, 17 Aug 2022 15:31:29 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches Subject: Re: [patch] libgomp/splay-tree.h: Fix splay_tree_prefix handling Message-ID: Reply-To: Jakub Jelinek References: <20aab88c-3970-1ac8-92c2-cc2e03e8296e@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <20aab88c-3970-1ac8-92c2-cc2e03e8296e@codesourcery.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 13:31:36 -0000 On Fri, Jul 22, 2022 at 11:47:42AM +0200, Tobias Burnus wrote: > As is, it is only a cleanup/consistency patch. > > However, I did run into this issue when working on the reverse-offload > implementation (to handle reverse lookups of vars and functions). > > OK for mainline? > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > libgomp/splay-tree.h: Fix splay_tree_prefix handling > > When splay_tree_prefix is defined, the .h file > defines splay_* macros to add the prefix. However, > before those were only unset when additionally > splay_tree_c was defined. > Additionally, for consistency undefine splay_tree_c > also when no splay_tree_prefix is defined - there > is no interdependence either. > > libgomp/ChangeLog: > > * splay-tree.h: Fix splay_* macro unsetting if > splay_tree_prefix is defined. > > libgomp/splay-tree.h | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) Ok. Jakub