From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>, Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++, v2: Implement C++23 P2071R2 - Named universal character escapes [PR106648]
Date: Tue, 30 Aug 2022 23:37:07 +0200 [thread overview]
Message-ID: <Yw6DA3MhofyzWnje@tucnak> (raw)
In-Reply-To: <Yw5+nPD8O+JTx3uL@tucnak>
On Tue, Aug 30, 2022 at 11:18:20PM +0200, Jakub Jelinek via Gcc-patches wrote:
> On Tue, Aug 30, 2022 at 09:10:37PM +0000, Joseph Myers wrote:
> > I'm seeing build failures of glibc for powerpc64, as illustrated by the
> > following C code:
> >
> > #if 0
> > \NARG
> > #endif
> >
> > (the actual sysdeps/powerpc/powerpc64/sysdep.h code is inside #ifdef
> > __ASSEMBLER__).
> >
> > This shows some problems with this feature - and with delimited escape
> > sequences - as it affects C. It's fine to accept it as an extension
> > inside string and character literals, because \N or \u{...} would be
> > invalid in the absence of the feature (i.e. the syntax for such literals
> > fails to match, meaning that the rule about undefined behavior for a
> > single ' or " as a pp-token applies). But outside string and character
> > literals, the usual lexing rules apply, the \ is a pp-token on its own and
> > the code is valid at the preprocessing level, and with expansion of macros
> > appearing before or after the \ (e.g. u defined as a macro in the \u{...}
> > case) it may be valid code at the language level as well. I don't know
> > what older C++ versions say about this, but for C this means e.g.
> >
> > #define z(x) 0
> > #define a z(
> > int x = a\NARG);
> >
> > needs to be accepted as expanding to "int x = 0;", not interpreted as
> > using the \N feature in an identifier and produce an error.
>
> Thanks, will look at it tomorrow.
If
#define z(x) 0
#define a z(
int x = a\NARG);
is valid in C and C++ <= 20 then
#define z(x) 0
#define a z(
int x = a\N{LATIN SMALL LETTER A WITH ACUTE});
is too and shall preprocess to int x = 0; too.
Which would likely mean that we want to only handle it in identifiers if
in C++23 and not actually treat it as an extension except in literals.
Jason, your toughts about that?
Jakub
next prev parent reply other threads:[~2022-08-30 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 18:18 [PATCH] c++: " Jakub Jelinek
2022-08-22 15:50 ` [PATCH] c++: Predefine __cpp_named_character_escapes=202207L for C++23 [PR106648] Jakub Jelinek
2022-08-24 20:22 ` [PATCH] c++: Implement C++23 P2071R2 - Named universal character escapes [PR106648] Jason Merrill
2022-08-25 8:49 ` [PATCH] c++, v2: " Jakub Jelinek
2022-08-25 13:34 ` Jason Merrill
2022-08-30 21:10 ` Joseph Myers
2022-08-30 21:18 ` Jakub Jelinek
2022-08-30 21:37 ` Jakub Jelinek [this message]
2022-08-31 14:18 ` Jason Merrill
2022-08-31 14:35 ` Jakub Jelinek
2022-08-31 14:52 ` Jason Merrill
2022-08-31 15:07 ` Jakub Jelinek
2022-08-31 15:25 ` Jakub Jelinek
2022-08-31 16:14 ` Jason Merrill
2022-09-01 11:14 ` Jakub Jelinek
2022-09-01 19:00 ` Jason Merrill
2022-09-01 20:23 ` Jakub Jelinek
2022-09-03 10:29 ` [PATCH] libcpp, v3: Named universal character escapes and delimited escape sequence tweaks Jakub Jelinek
2022-09-03 10:54 ` Jakub Jelinek
2022-09-05 7:54 ` Jakub Jelinek
2022-09-07 1:32 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw6DA3MhofyzWnje@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).