From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D29A43858D32 for ; Tue, 23 Aug 2022 07:58:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D29A43858D32 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-4lhFcDmCM3OoX3fEJBPVJg-1; Tue, 23 Aug 2022 03:58:10 -0400 X-MC-Unique: 4lhFcDmCM3OoX3fEJBPVJg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 608AA101AA4E; Tue, 23 Aug 2022 07:58:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14159C15BB3; Tue, 23 Aug 2022 07:58:09 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 27N7w7oJ638526 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 23 Aug 2022 09:58:07 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 27N7w6Mn638525; Tue, 23 Aug 2022 09:58:06 +0200 Date: Tue, 23 Aug 2022 09:58:06 +0200 From: Jakub Jelinek To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org Subject: Patch ping (Re: [PATCH] Implement __builtin_issignaling) Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, LOTS_OF_MONEY, RCVD_IN_DNSWL_NONE, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 07:58:14 -0000 On Tue, Aug 16, 2022 at 11:41:06AM +0000, Richard Biener wrote: > I'm OK with the rest of the patch if Joseph doesn't have comments > on the actual issignaling lowerings (which I didn't review for > correctness due to lack of knowledge). I'd like to ping this patch. Patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599697.html with https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599794.html https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599800.html incremental additions. gcc/testsuite/gcc.dg/torture/builtin-issignaling-1.c's testcase f4-f7 functions (i.e. functions which just return __builtin_issignaling of the argument which is float, double, long double and _Float128 on x86_64-linux) with -O2 are in assembly: .p2align 4 .globl f4 .type f4, @function f4: .LFB0: .cfi_startproc movd %xmm0, %eax xorl $4194304, %eax andl $2147483647, %eax cmpl $2143289344, %eax seta %al movzbl %al, %eax ret .cfi_endproc .LFE0: .size f4, .-f4 .p2align 4 .globl f5 .type f5, @function f5: .LFB1: .cfi_startproc movabsq $9221120237041090560, %rdx movq %xmm0, %rax btcq $51, %rax btrq $63, %rax cmpq %rax, %rdx setb %al movzbl %al, %eax ret .cfi_endproc .LFE1: .size f5, .-f5 .p2align 4 .globl f6 .type f6, @function f6: .LFB2: .cfi_startproc fldt 8(%rsp) fstpt -24(%rsp) movl -20(%rsp), %edx movl -24(%rsp), %eax movl %edx, %ecx negl %eax orl -24(%rsp), %eax notl %edx xorl $1073741824, %ecx shrl $31, %eax orl %ecx, %eax movzwl -16(%rsp), %ecx cmpl $-1073741824, %eax movl %ecx, %esi seta %al notl %ecx andl $32767, %esi movzbl %al, %eax negl %esi testw $32767, %cx sete %cl andl %esi, %edx movzbl %cl, %ecx shrl $31, %edx andl %ecx, %eax orl %edx, %eax ret .cfi_endproc .LFE2: .size f6, .-f6 .p2align 4 .globl f7 .type f7, @function f7: .LFB3: .cfi_startproc movaps %xmm0, -24(%rsp) movq -24(%rsp), %rsi movq -16(%rsp), %rdi movq %rsi, %rdx movq %rdi, %rax negq %rdx btcq $47, %rax orq %rsi, %rdx shrq $63, %rdx orq %rdx, %rax movabsq $9223231299366420480, %rdx btrq $63, %rax cmpq %rax, %rdx setb %al movzbl %al, %eax ret .cfi_endproc .LFE3: .size f7, .-f7 Thanks Jakub