Re: [PATCH] Fix up dump_printf_loc format attribute and adjust uses [PR106782]

[Jakub Jelinek <jakub@redhat.com>]

On Thu, Sep 01, 2022 at 09:05:41AM +0000, Richard Biener wrote:
> > As discussed on IRC, the r13-2299-g68c61c2daa1f bug only got missed
> > because dump_printf_loc had incorrect format attribute and therefore
> > almost no -Wformat=* checking was performed on it.
> > 3, 0 are suitable for function with (whatever, whatever, const char *, va_list)
> > arguments, not for (whatever, whatever, const char *, ...), that one should
> > use 3, 4.
> > 
> > The following patch fixes that and adjusts all spots to fix warnings.
> > In many cases it is just through an ugly cast (for %G casts to gimple *
> > from gassign */gphi * and the like and for %p casts to void * from slp_node
> > etc.).
> > There are 3 spots where the mismatch was worse though, two using %u or %d
> > for unsigned HOST_WIDE_INT argument and one %T for enum argument (promoted
> > to int).
> 
> Those 3 spots might be worth backporting?  With -fopt-info-* they might
> run into crashes.

Yes, I'll do it soon.

> > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> 
> OK.

Thanks.

	Jakub