From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 67AA03858400 for ; Mon, 5 Sep 2022 16:00:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 67AA03858400 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662393622; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k3VSE3ZuKMO56cGngj2y/iSdewwJjlI41nmaLjKZk6Q=; b=XjHKBjzDhr1JiBL6cIx6/+e0c24z6gSceI1fC71l5tFZbc30uNG7LzOQMqpQGWcs0bf5o5 HOOkfCSgxv7ivhcMAQ5jNFaOGWNOqrRDD7xl1WaRcCFaqWDTwE5AIy77/M3jlo/A7P/1c5 JVwT4oaJeLnzzyrBG16gjzAvnaDEkBM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-wGg-jIf6PwGedLWtdGikZQ-1; Mon, 05 Sep 2022 12:00:18 -0400 X-MC-Unique: wGg-jIf6PwGedLWtdGikZQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE91C3C01DF2; Mon, 5 Sep 2022 16:00:17 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 871C0492C3B; Mon, 5 Sep 2022 16:00:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 285G0ERi182112 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 5 Sep 2022 18:00:14 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 285G0Doi182111; Mon, 5 Sep 2022 18:00:13 +0200 Date: Mon, 5 Sep 2022 18:00:12 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches@gcc.gnu.org Subject: Re: [committed] openmp: Partial OpenMP 5.2 doacross and omp_cur_iteration support Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Sep 05, 2022 at 03:01:07PM +0200, Tobias Burnus wrote: > On 03.09.22 10:07, Jakub Jelinek wrote: > > The following patch implements part of the OpenMP 5.2 changes related > > to ordered loops ... > > Fortran bits to it attached. > > OK for mainline? > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > Fortran/openmp: Partial OpenMP 5.2 doacross and omp_cur_iteration support > > Add the Fortran support to the ME/C/C++ commit > r13-2388-ga651e6d59188da8992f8bfae2df1cb4e6316f9e6 > > gcc/fortran/ChangeLog: > > * dump-parse-tree.cc (show_omp_namelist, show_omp_clauses): Handle > omp_cur_iteration and distinguish doacross/depend: s/:/./ > * gfortran.h (enum gfc_omp_depend_doacross_op): Renamed from > gfc_omp_depend_op. > (enum gfc_omp_depend_doacross_op): Add OMP_DOACROSS_SINK_FIRST, > Rename OMP_DEPEND_SINK to OMP_DOACROSS_SINK. > (gfc_omp_namelist) Handle renaming, rename depend_op to > depend_doacross_op. > (struct gfc_omp_clauses): Add doacross_source. > * openmp.cc (gfc_match_omp_depend_sink): Renamed to ... > (gfc_match_omp_doacross_sink): ... this; handle omp_all_memory. > (enum omp_mask2): Add OMP_CLAUSE_DOACROSS. > (gfc_match_omp_clauses): Handle 'doacross' and syntax changes to > depend. > (gfc_match_omp_depobj): Simplify as sink/source are now impossible. > (gfc_match_omp_ordered_depend): Request OMP_CLAUSE_DOACROSS. > (resolve_omp_clauses): Update sink/source checks. > (gfc_resolve_omp_directive): Resolve EXEC_OMP_ORDERED clauses. > * parse.cc (decode_omp_directive): Handle 'ordered doacross'. > * trans-openmp.cc (gfc_trans_omp_clauses): Handle doacross. > (gfc_trans_omp_do): Fix OMP_FOR_ORIG_DECLS handling if 'ordered' > clause is present. > (gfc_trans_omp_depobj): Update for member name change. > > libgomp/ChangeLog: > > * libgomp.texi (OpenMP 5.2): Update doacross/omp_cur_iteration status. > > gcc/testsuite/ChangeLog: > > * gfortran.dg/gomp/all-memory-1.f90: Update dg-error. > * gfortran.dg/gomp/depend-iterator-2.f90: Likewise. > * gfortran.dg/gomp/depobj-2.f90: Likewise. > * gfortran.dg/gomp/doacross-5.f90: New test. > * gfortran.dg/gomp/doacross-6.f90: New test. Otherwise LGTM. Jakub