From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7A6663858299 for ; Wed, 7 Sep 2022 13:51:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A6663858299 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 287DE8Il010250; Wed, 7 Sep 2022 13:51:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=s7Q8rts7zCTekQasxGwpSYJ2JovUgPXOmAYz/WSUaCs=; b=lwNSkynQq/9eX0mhfWYA3JeLlMWzidQohobQqCYQzDYFNgnhOHDX3eyukstDnw9epnkb PxuyxqcxigOfD1jIGjXz89F8Bn/VRPLQ/I3LSZaImzq52FOBtwIwGcROT6xu6WTmO1zI tbl09M5i4IYd+DvdyCnspkycxkmWCe7UqnpPT8Gz1TqtQ4ExcsffNU4qHtDjVNCMji3A I9qI/bv0HP/98+owkCCPyYs3u61hWD9yjJtS91OYH+onb3IYTiKnU/ooOv96eKYCsD/N CN3xgY4iIDYu4wn2lV9bO6ys2tyfkbmIwldEaHDsBsCPPEy6p7ot2/2lMLTg1ORna925 Jw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jeu5m35cn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Sep 2022 13:51:22 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 287DadoL012639; Wed, 7 Sep 2022 13:51:22 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jeu5m35ca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Sep 2022 13:51:22 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 287DoYs6024060; Wed, 7 Sep 2022 13:51:21 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma03dal.us.ibm.com with ESMTP id 3jbxja8mb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Sep 2022 13:51:21 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 287DpKYX26411424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Sep 2022 13:51:20 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7EF926A04F; Wed, 7 Sep 2022 13:51:19 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CCD746A04D; Wed, 7 Sep 2022 13:51:18 +0000 (GMT) Received: from li-be644d4c-2c59-11b2-a85c-bc3dba3ed00b.ibm.com (unknown [9.160.66.124]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTPS; Wed, 7 Sep 2022 13:51:18 +0000 (GMT) Date: Wed, 7 Sep 2022 08:51:17 -0500 From: "Paul A. Clarke" To: Segher Boessenkool Cc: HAO CHEN GUI , Peter Bergner , gcc-patches , David Subject: Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions Message-ID: References: <3cd458bc-b01f-cc61-241a-f12d6a49bc87@linux.ibm.com> <20220902155604.GO25951@gate.crashing.org> <20220906171906.GF25951@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220906171906.GF25951@gate.crashing.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: v9DwytE8NbaTiNtAOr8ZoLgfy-2_aBCH X-Proofpoint-ORIG-GUID: ftR6LvyswovKo0b3LIsyNHWMjxhBfN7s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-07_07,2022-09-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 clxscore=1011 priorityscore=1501 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209070053 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 06, 2022 at 12:19:06PM -0500, Segher Boessenkool wrote: > On Mon, Sep 05, 2022 at 02:36:30PM +0800, HAO CHEN GUI wrote: > > On 2/9/2022 下午 11:56, Segher Boessenkool wrote: > > >> - const signed long __builtin_vsx_scalar_extract_exp (double); > > >> + const unsigned long long __builtin_vsx_scalar_extract_exp (double); > > >> VSEEDP xsxexpdp {} > > >> > > >> - const signed long __builtin_vsx_scalar_extract_sig (double); > > >> + const unsigned long long __builtin_vsx_scalar_extract_sig (double); > > >> VSESDP xsxsigdp {} > > > This also brings these legacy builtins in line with the vec_ versions, > > > which are the preferred builtins (they are defined in the PVIPR). > > > > The return type of vec_ version built-ins are different than their definition > > in PVIPR. In PVIPR, they're vector unsigned int or vector unsigned long long. > > Shall we correct them? > > > > const vd __builtin_vsx_extract_exp_dp (vd); > > VEEDP xvxexpdp {} > > > > const vf __builtin_vsx_extract_exp_sp (vf); > > VEESP xvxexpsp {} > > > > const vd __builtin_vsx_extract_sig_dp (vd); > > VESDP xvxsigdp {} > > > > const vf __builtin_vsx_extract_sig_sp (vf); > > VESSP xvxsigsp {} > > Those are the vsx_ versions. I'm not sure what you're asking. > > It won't be easy at all to change types from vector integer to vector > float, it will break all over. A compatibility nightmare. It is better > if you can show the current stuff cannot ever work, it's not a problem > to replace it in that case. I think Hao Chen is concerned about the return types: > > const vd __builtin_vsx_extract_exp_dp (vd); > > VEEDP xvxexpdp {} Per PVIPR, this should return vector unsigned long long ("vull" not "vd"). > > const vf __builtin_vsx_extract_exp_sp (vf); > > VEESP xvxexpsp {} This should return vector unsigned int ("vui" not "vf"). > > const vd __builtin_vsx_extract_sig_dp (vd); > > VESDP xvxsigdp {} This should return vector unsigned long long ("vull" not "vd"). > > const vf __builtin_vsx_extract_sig_sp (vf); > > VESSP xvxsigsp {} This should return vector unsigned int ("vui" not "vf"). PC