public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	Thomas Schwinge <thomas@codesourcery.com>,
	Andrew Stubbs <ams@codesourcery.com>,
	Tom de Vries <tdevries@suse.de>
Subject: Re: [Patch] libgomp.texi: Document libmemkind + nvptx/gcn specifics
Date: Thu, 8 Sep 2022 17:35:31 +0200	[thread overview]
Message-ID: <YxoLw/+SiFNDGRMc@tucnak> (raw)
In-Reply-To: <a73c933f-c633-cada-9a05-8db3f041d797@codesourcery.com>

On Mon, Aug 29, 2022 at 12:54:33PM +0200, Tobias Burnus wrote:
> I had this patch lying around since about half a year. I did tweak and agumented it
> a bit today, but finally want to get rid of it (locally - by getting it committed) ...
> 
> This patch changes -misa to -march for nvptx (the latter is now an alias
> for the former), it adds a new section about libmemkind and some information
> about interns of our nvptx/gcn implementation. (The latter should be mostly
> correct, but I might have missed some fine print or a more recent update.)
> 
> OK for mainline?
> 
> Tobias
> 
> 
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

> libgomp.texi: Document libmemkind + nvptx/gcn specifics
> 
> libgomp/ChangeLog:
> 
> 	* libgomp.texi (OpenMP-Implementation Specifics): New; add libmemkind
> 	section; move OpenMP Context Selectors from ...
> 	(Offload-Target Specifics): ... here; add 'AMD Radeo (GCN)' and
> 	'nvptx' sections.
> +All OpenMP and OpenACC levels are used, i.e.
> +@itemize
> +@item OpenMP's simd and OpenACC's vector map to work items (thread)
> +@item OpenMP's threads (``parallel'') and OpenACC's workers map
> +      to wavefronts
> +@item OpenMP's teams and OpenACC's gang use use a threadpool with the

s/use use/use/

> +All OpenMP and OpenACC levels are used, i.e.
> +@itemize
> +@item OpenMP's simd and OpenACC's vector map to threads
> +@item OpenMP's threads (``parallel'') and OpenACC's workers map to warps
> +@item OpenMP's teams and OpenACC's gang use use a threadpool with the

Again.

Otherwise LGTM.

	Jakub


      parent reply	other threads:[~2022-09-08 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 10:54 Tobias Burnus
2022-08-29 10:54 ` Tobias Burnus
2022-09-08 15:35 ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxoLw/+SiFNDGRMc@tucnak \
    --to=jakub@redhat.com \
    --cc=ams@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tdevries@suse.de \
    --cc=thomas@codesourcery.com \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).