From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D6F503858C52 for ; Fri, 9 Sep 2022 15:31:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6F503858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662737510; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=imJR2fl8/DdYbJD0hW1UdVLYWyx+/5nH+hIeD250Hrc=; b=NNu8PhcQkCOcciUOhJjFC8YP3CY2NMxiykcTPqMEAWTRxOBk7Dm6YyMtKq1Srygy0w0JNO PMIBOEOKsWAu5WXTRVJ1PjZD0YWJyAmvewN5hWl2BUA1yf2zTl28t4Wb5d0AdU1fOMm4lL bTJpNHCpnEAJwBQm0L71LCeu7AmM9O0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-80-Hn1KsxWdPEe7SSJjs3NJhA-1; Fri, 09 Sep 2022 11:31:46 -0400 X-MC-Unique: Hn1KsxWdPEe7SSJjs3NJhA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6FBE980418F; Fri, 9 Sep 2022 15:31:46 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 304782166B29; Fri, 9 Sep 2022 15:31:46 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 289FVhwg1598502 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 9 Sep 2022 17:31:44 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 289FVgiG1598501; Fri, 9 Sep 2022 17:31:42 +0200 Date: Fri, 9 Sep 2022 17:31:42 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , Andrew Stubbs Subject: Re: [Patch][2/3] GCN: libgomp+mkoffload.cc: Prepare for reverse offload fn lookup Message-ID: Reply-To: Jakub Jelinek References: <40563a1c-49ef-a185-3c01-9f717cd48fc5@codesourcery.com> <9b367f13-dad2-5151-45a6-ae5dbc7950aa@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <9b367f13-dad2-5151-45a6-ae5dbc7950aa@codesourcery.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Aug 25, 2022 at 05:38:58PM +0200, Tobias Burnus wrote: > On 25.08.22 16:54, Tobias Burnus wrote: > > The attached patch prepare for reverse-offload device->host > function-address lookup by requesting (if needed) the on-device address. > > > This patch adds the actual implementation for GCN. A variant would be > to only generate .offload_func_table inside mkoffload when > OMP_REQUIRES_REVERSE_OFFLOAD has been requested. > > This is currently effectively a no op as with [1/3] patch, always NULL > is passed and as GOMP_OFFLOAD_get_num_devices returns <= 0 as soon as > 'omp requires reverse_offload' has been specified. > > OK for mainline? > > Tobias > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > GCN: libgomp+mkoffload.cc: Prepare for reverse offload fn lookup > > Add support to GCN for reverse lookup of function name to prepare for > 'omp target device(ancestor:1)'. > > gcc/ChangeLog: > > * config/gcn/mkoffload.cc (process_asm): Create .offload_func_table, > similar to pre-existing .offload_var_table. > > libgomp/ChangeLog: > > * plugin/plugin-gcn.c (GOMP_OFFLOAD_load_image): Read > .offload_func_table to populate rev_fn_table when requested. Ok. Jakub