From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4B4543858429 for ; Fri, 9 Sep 2022 22:17:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B4543858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662761871; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vevrs3XFMhfnAejahBdCkXodENU3jYF1wK+RIUHeF60=; b=L1dosytK+TXiIhyplRh4QAfLt0XdlKRGfdqfI2Cr7UY4KJaYgoUyhvfbKwe5wbo+irB0// hziqiLstGB8gYwH4F9g8AgOIhVPpUq04jk6k84sI+f7R7Mh5MvjPJ7Ub6WLPAUeF2aZZ1Z JfrEycBr0VL7IPvnIxjpK/JkF918Exs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-42-fmLUnvRlPgKMIQZ9gmu65g-1; Fri, 09 Sep 2022 18:17:50 -0400 X-MC-Unique: fmLUnvRlPgKMIQZ9gmu65g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 323F738041DD; Fri, 9 Sep 2022 22:17:50 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4EAF40334C; Fri, 9 Sep 2022 22:17:49 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 289MHkNV1622257 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 10 Sep 2022 00:17:47 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 289MHiG21622256; Sat, 10 Sep 2022 00:17:44 +0200 Date: Sat, 10 Sep 2022 00:17:43 +0200 From: Jakub Jelinek To: Iain Sandoe Cc: Rainer Orth , GCC Patches , Marcel Vollweiler Subject: Re: [PATCH] OpenMP, libgomp: Environment variable syntax extension. Message-ID: Reply-To: Jakub Jelinek References: <73621930-22ce-c3f1-61e0-f15683f8b281@codesourcery.com> <055f7cfb-2849-ba5a-a161-13333e19e538@codesourcery.com> <7dc0eaf0-a3ed-8145-c43a-e9bb063f6acd@codesourcery.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Sep 09, 2022 at 11:13:52PM +0100, Iain Sandoe wrote: > We already have such a header … > include/environ.h Ah, ok, then please just use it. Seems libgomp Makefile.am already includes -I$(top_srcdir)/../include So just include that and remove the extern char **environ; from the constructor. Jakub