From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B6A063858C52 for ; Fri, 23 Sep 2022 07:44:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6A063858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663919094; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=g58CnosjMiiazTiKWbeYQs8sV7KrwYN9A/2WsqLWRNQ=; b=AGCSHtG7r1VP5prwn//kRq/1mFEpXM2UwJvtRA1FbRIN45gNMokniluGS6J7SGAQ4cewJf Iwo3w80/h1IN3fFWJBVBrmyL9kAHFKk/s1MPYvNZEMKHoGEc/GFczMYL7u7OIZxtEPdmcZ QV8znM9FwJ7IsMtfrBZkr9RPXiVRb94= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-OPfdeEctOSq77tkHq-Ubbw-1; Fri, 23 Sep 2022 03:44:51 -0400 X-MC-Unique: OPfdeEctOSq77tkHq-Ubbw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 29ABB800B30; Fri, 23 Sep 2022 07:44:51 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC1361400AFC; Fri, 23 Sep 2022 07:44:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 28N7impx201382 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 23 Sep 2022 09:44:48 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 28N7il8s201381; Fri, 23 Sep 2022 09:44:47 +0200 Date: Fri, 23 Sep 2022 09:44:47 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/106922 - missed FRE/PRE Message-ID: Reply-To: Jakub Jelinek References: <20220922111009.3EF0413AA5@imap2.suse-dmz.suse.de> MIME-Version: 1.0 In-Reply-To: <20220922111009.3EF0413AA5@imap2.suse-dmz.suse.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 22, 2022 at 01:10:08PM +0200, Richard Biener via Gcc-patches wrote: > * g++.dg/tree-ssa/pr106922.C: Adjust. > --- a/gcc/testsuite/g++.dg/tree-ssa/pr106922.C > +++ b/gcc/testsuite/g++.dg/tree-ssa/pr106922.C > @@ -87,5 +87,4 @@ void testfunctionfoo() { > } > } > > -// { dg-final { scan-tree-dump-times "Found fully redundant value" 4 "pre" { xfail { ! lp64 } } } } > -// { dg-final { scan-tree-dump-not "m_initialized" "cddce3" { xfail { ! lp64 } } } } > +// { dg-final { scan-tree-dump-not "m_initialized" "dce3" } } I've noticed +UNRESOLVED: g++.dg/tree-ssa/pr106922.C -std=gnu++20 scan-tree-dump-not dce3 "m_initialized" +UNRESOLVED: g++.dg/tree-ssa/pr106922.C -std=gnu++2b scan-tree-dump-not dce3 "m_initialized" with this change, both on x86_64 and i686. The dump is still cddce3, additionally as the last reference to the pre dump is gone, not sure it is worth creating that dump. With the following patch, there aren't FAILs nor UNRESOLVED tests with GXX_TESTSUITE_STDS=98,11,14,17,20,2b make check-g++ RUNTESTFLAGS="--target_board=unix\{-m32,-m64\} dg.exp='pr106922.C'" Ok for trunk? 2022-09-23 Jakub Jelinek PR tree-optimization/106922 * g++.dg/tree-ssa/pr106922.C: Scan in cddce3 dump rather than dce3. Remove -fdump-tree-pre-details from dg-options. --- gcc/testsuite/g++.dg/tree-ssa/pr106922.C.jj 2022-09-23 09:02:57.011311664 +0200 +++ gcc/testsuite/g++.dg/tree-ssa/pr106922.C 2022-09-23 09:41:06.348797951 +0200 @@ -1,5 +1,5 @@ // { dg-require-effective-target c++20 } -// { dg-options "-O2 -fdump-tree-pre-details -fdump-tree-cddce3" } +// { dg-options "-O2 -fdump-tree-cddce3" } template struct __new_allocator { void deallocate(int *, int) { operator delete(0); } @@ -87,4 +87,4 @@ void testfunctionfoo() { } } -// { dg-final { scan-tree-dump-not "m_initialized" "dce3" } } +// { dg-final { scan-tree-dump-not "m_initialized" "cddce3" } } Jakub