From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 87CC63858437 for ; Wed, 14 Sep 2022 11:21:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87CC63858437 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663154473; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=85MnnaW9xTjy9Smvm6xP99jJ9QLb4+OON4e4+Rmh/IE=; b=Xg08RhSq52pAHGWuzwkLqPNkYtobCJRuK8CaXudp4yRuSfgQWCvSuGce2Eyfc50gRRdGMH oO5Cf1h8rBLP3y0e2M2015RCtyyeYstoNL+FJs6KVZ7jv2As4DZMO3CS1eGyUqXoIStFxM GyTFLfJTSf0+NiKxvR0rbHXVzS/Sl1k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-125-5pr-vTI6OJGibt3EsQEFtA-1; Wed, 14 Sep 2022 07:21:08 -0400 X-MC-Unique: 5pr-vTI6OJGibt3EsQEFtA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B264C185A792; Wed, 14 Sep 2022 11:21:07 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6CD8E1121314; Wed, 14 Sep 2022 11:21:07 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 28EBL4SJ1975750 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 14 Sep 2022 13:21:04 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 28EBL3Rw1975749; Wed, 14 Sep 2022 13:21:03 +0200 Date: Wed, 14 Sep 2022 13:21:03 +0200 From: Jakub Jelinek To: Julian Brown Cc: gcc-patches@gcc.gnu.org, tobias@codesourcery.com, fortran@gcc.gnu.org Subject: Re: [PATCH v3 03/11] OpenMP/OpenACC struct sibling list gimplification extension and rework Message-ID: Reply-To: Jakub Jelinek References: <76cdecccc148288ba2b1516b1c69099ba12fcfe4.1663101299.git.julian@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <76cdecccc148288ba2b1516b1c69099ba12fcfe4.1663101299.git.julian@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 13, 2022 at 02:01:44PM -0700, Julian Brown wrote: > static tree > -insert_struct_comp_map (enum tree_code code, tree c, tree struct_node, > - tree prev_node, tree *scp) > +build_struct_comp_nodes (enum tree_code code, tree grp_start, tree grp_end, > + tree *extra_node) I'd rename even this function, say to build_omp_struct_comp_nodes. So that it is clear it is OpenMP/OpenACC specific. Otherwise LGTM. Jakub