From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BCF743857B87 for ; Wed, 14 Sep 2022 13:26:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BCF743857B87 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663162019; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-message-id: in-reply-to:in-reply-to:references:references; bh=IeCRPeONPyCOlklihdMybQoAfDGGpZwQGM6gr2lGhes=; b=eBpmiKFn5yCRGajfyejNuPAj3Dq2tNKw5ht+IhRwwTLWoFipyGGXr3+aYiyAsskwYkSAyM PRoV5WqFKWD4YxMYJdFZPM16I60jFBcWZjZMvzvjfQvvKhb/7bBhKAb8oqOUZEgdTSJWsY QVR1zPyUewAPlGOdkw+q3xeFOjWyfEk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-599-5AxnKmTiPqaaFurXYZ3a6g-1; Wed, 14 Sep 2022 09:26:54 -0400 X-MC-Unique: 5AxnKmTiPqaaFurXYZ3a6g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D38A386E923; Wed, 14 Sep 2022 13:26:53 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91CAE40C6EC2; Wed, 14 Sep 2022 13:26:52 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 28EDQno61976185 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 14 Sep 2022 15:26:50 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 28EDQn3F1976184; Wed, 14 Sep 2022 15:26:49 +0200 Resent-From: Jakub Jelinek Resent-Date: Wed, 14 Sep 2022 15:26:49 +0200 Resent-Message-ID: Resent-To: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, tobias@codesourcery.com, cltang@codesourcery.com Date: Wed, 14 Sep 2022 15:06:32 +0200 From: Jakub Jelinek To: Julian Brown Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, tobias@codesourcery.com, cltang@codesourcery.com Subject: Re: [PATCH v3 07/11] OpenMP/OpenACC: Reindent TO/FROM/_CACHE_ stanza in {c_}finish_omp_clause Message-ID: Reply-To: Jakub Jelinek References: <4c462bdaea797b68b36cc58154dfee31213072b2.1663101299.git.julian@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <4c462bdaea797b68b36cc58154dfee31213072b2.1663101299.git.julian@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 13, 2022 at 02:03:17PM -0700, Julian Brown wrote: > This patch trivially adds braces and reindents the > OMP_CLAUSE_TO/OMP_CLAUSE_FROM/OMP_CLAUSE__CACHE_ stanza in > c_finish_omp_clause and finish_omp_clause, in preparation for the > following patch (to clarify the diff a little). > > 2022-09-13 Julian Brown > > gcc/c/ > * c-typeck.cc (c_finish_omp_clauses): Add braces and reindent > OMP_CLAUSE_TO/OMP_CLAUSE_FROM/OMP_CLAUSE__CACHE_ stanza. > > gcc/cp/ > * semantics.cc (finish_omp_clause): Add braces and reindent > OMP_CLAUSE_TO/OMP_CLAUSE_FROM/OMP_CLAUSE__CACHE_ stanza. Not very happy about this because it ruins git blame, some vars can be declared separately from initializing them and be thus usable in switches. But I see you use there classes with ctors... So ok. Jakub