From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 197AD3853543 for ; Thu, 6 Oct 2022 07:06:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 197AD3853543 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2966SM8t040749 for ; Thu, 6 Oct 2022 07:06:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=ok0ca8LXxlNF6FYhkoHlU/41lKHFGRYMYGSTFS5jBd8=; b=Zn3AB+VZ8esGXe5kDXX8KSYdVtiech8MT7rS5HTqymPZonSR2U7c4kDIJ+HFW3J8wB12 TfkYSflTMmwO9NFgL472SeS3BpSQphFQoUQ/IFCXgtSdrXUWmvTytukCOllgJ8KYaXkF ZP4b6WarMHv5A/NWAKcRWAbnRgyukyCfew0TxieL3LQyg/Dn/EY4P98duv3mpURlpmfz mKF16mGddu6LIWe+VuFqC5m74+IncloyHpZvdzQSnFNGzyhBv1VOAtuiV+aVZ8yZu4/t JxkRmJLvqC+U+H2EMsBQWF9Go7IZVPW3jOKstpmQh7ptA601e3SAYUBIKv7d9k5kKE0J RA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k1ssgh2qq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Oct 2022 07:06:21 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2966UBc2008799 for ; Thu, 6 Oct 2022 07:06:20 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k1ssgh2pp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Oct 2022 07:06:20 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29676GH2008191; Thu, 6 Oct 2022 07:06:19 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06ams.nl.ibm.com with ESMTP id 3jxctj6mp6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Oct 2022 07:06:19 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29676Gwe1835768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Oct 2022 07:06:16 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B448752051; Thu, 6 Oct 2022 07:06:16 +0000 (GMT) Received: from li-42a4824c-28a0-11b2-a85c-f55c0d5956ce.ibm.com (unknown [9.145.175.156]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 82E495204F; Thu, 6 Oct 2022 07:06:16 +0000 (GMT) Date: Thu, 6 Oct 2022 09:06:16 +0200 From: Stefan Schulze Frielinghaus To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cselib: Skip BImode while keeping track of subvalue relations [PR107088] Message-ID: References: <20221004112849.27678-1-stefansf@linux.ibm.com> <43be68a9-3069-26eb-8b1a-4f9215e02f8d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <43be68a9-3069-26eb-8b1a-4f9215e02f8d@gmail.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 7Rmdv9syS_bYdmtsozDICH2EJ5hijpse X-Proofpoint-GUID: H6LlhaWSKb9zOErShy92SGdh1SqUo9vk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-05_05,2022-10-05_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxlogscore=664 bulkscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210060042 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 05, 2022 at 08:48:13PM -0600, Jeff Law via Gcc-patches wrote: > > On 10/4/22 05:28, Stefan Schulze Frielinghaus via Gcc-patches wrote: > > For BImode get_narrowest_mode evaluates to QImode but BImode < QImode. > > Thus FOR_EACH_MODE_UNTIL never reaches BImode and iterates until OImode > > for which no wider mode exists so we end up with VOIDmode and fail. > > Fixed by adding a size guard so we effectively skip BImode. > > > > Bootstrap and regtest are currently running on x64. Assuming they pass > > ok for mainline? > > > > gcc/ChangeLog: > > > > PR rtl-optimization/107088 > > * cselib.cc (new_cselib_val): Skip BImode while keeping track of > > subvalue relations. > > OK.  And FWIW, this fixes the various failures I saw in my tester due to the > cselib patches. Thanks for testing, too! Out of curiosity which target is your tester? I gave it a try on x64 and AArch64 for which bootstrap went fine and regtest showed no difference, and of course, for s390x regtest went for the better.