From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D6B533858D37 for ; Thu, 6 Oct 2022 22:19:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6B533858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665094760; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=geU0I+MyLuoJujew6ljP4y3yITRdIaUzhHBq5/F79eM=; b=T74Ke+2JZPPOFAp+TMKY1A4k7v8doZFZfLIMgruepwyPvXQV8WGpGVeKef7SizMTGNu95A C+ZWPdhZQSwKJ+KfCJFHTBmBI7/8CKy6erCCXV9CZlzS4k7Hk1moh2UY66bPa+/TxQTOQh oLYEVuguUQqh8CI9HuJVVR+3Dg+ZJaI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-116-PoKDkDkaMfOeO77LVrwqNg-1; Thu, 06 Oct 2022 18:19:15 -0400 X-MC-Unique: PoKDkDkaMfOeO77LVrwqNg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8862101A528; Thu, 6 Oct 2022 22:19:14 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 848D99D493; Thu, 6 Oct 2022 22:19:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 296MJBK62179181 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 7 Oct 2022 00:19:11 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 296MJATX2174844; Fri, 7 Oct 2022 00:19:10 +0200 Date: Fri, 7 Oct 2022 00:19:09 +0200 From: Jakub Jelinek To: Joseph Myers Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: [committed] libgcc, arc: Fix build Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Thu, Oct 06, 2022 at 10:05:29PM +0000, Joseph Myers wrote: > I'm seeing the following build failure for arc-linux-gnu after this > commit. (Note that this is for building GCC *after* glibc, not for an > initial inhibit_libc bootstrap build of GCC.) > > In file included from > /scratch/jmyers/glibc-bot/src/gcc/libgcc/unwind-dw2.c:413: > ./md-unwind-support.h: In function 'arc_fallback_frame_state': > ./md-unwind-support.h:103:10: warning: assignment to 'struct sigcontext *' from incompatible pointer type 'mcontext_t *' [-Wincompatible-pointer-types] > 103 | sc = &rt_->uc.uc_mcontext; > | ^ > ./md-unwind-support.h:118:45: error: 'struct ' has no member named 'how' > 118 | fs->regs.reg[register_id_for_index[i]].how = REG_SAVED_OFFSET; > | ^ > /scratch/jmyers/glibc-bot/src/gcc/libgcc/shared-object.mk:14: recipe for target 'unwind-dw2.o' failed > > https://sourceware.org/pipermail/libc-testresults/2022q4/010333.html Oops, sorry. Missed one spot in the r13-3108-g146e45914032 change (my sed script didn't expect nested []s). Committed to trunk as obvious. 2022-10-07 Jakub Jelinek * config/arc/linux-unwind.h (arc_fallback_frame_state): Use fs->regs.how[X] instead of fs->regs.reg[X].how. --- libgcc/config/arc/linux-unwind.h.jj 2022-10-06 11:04:33.254058274 +0200 +++ libgcc/config/arc/linux-unwind.h 2022-10-07 00:10:24.353464043 +0200 @@ -115,7 +115,7 @@ arc_fallback_frame_state (struct _Unwind { if (register_id_for_index[i] == -1) continue; - fs->regs.reg[register_id_for_index[i]].how = REG_SAVED_OFFSET; + fs->regs.how[register_id_for_index[i]] = REG_SAVED_OFFSET; fs->regs.reg[register_id_for_index[i]].loc.offset = ((_Unwind_Ptr) &(regs[i])) - new_cfa; } Jakub