From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F1F0E385AC1B for ; Mon, 26 Sep 2022 16:26:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F1F0E385AC1B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664209580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n+JKYvAPV5XgKiA/EnA9xDUBpjvRmfJM5R+IncyXLRI=; b=UwysKD/grLXh2Lwnqkdb68IPb+mA0PJSioObOyrsZqLv8tqFso5SGIq8RvghcXal8w2xXK +jLSHaFtR/JtYsc/3kyFHdhcLv2W0ATCumasqlbB1YmYi3UE3sDFtINWjzahC/BYczFHpk sEeblYZGZG6nj83QcjGGzuQNWexAZL4= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-290-junj81mkPtyzMk-RtQ6QmA-1; Mon, 26 Sep 2022 12:26:19 -0400 X-MC-Unique: junj81mkPtyzMk-RtQ6QmA-1 Received: by mail-qv1-f72.google.com with SMTP id y16-20020a0cec10000000b004a5df9e16c6so4099027qvo.1 for ; Mon, 26 Sep 2022 09:26:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=n+JKYvAPV5XgKiA/EnA9xDUBpjvRmfJM5R+IncyXLRI=; b=zpuFJn51LJVYfvhni6asFFly/GVsQhO7qrYJSYaDUQ0DbVwAHZM1JrEC/aGEkETJUi EPvnXucQlhUG8frQI8W6q7B/1y5PM6k6EZMObbhDrobgHa2lVnT69flwdgWs2vkkeYaA YODxggh0p/58uieWZ0eYDi0+UDtAYjjYbHNk6SXI0yWNbvQVdmCyd5ws7zVTPYxKtAdi dASvA38w5bt8c/UIeuCquFO8FdHLiW4XKBNuf0sw881tj5H0pL7Jq9FhD5PXQzE8YY+D HdIj6l9TBEMAKTRPLjVVMGstH36SqOmVjKg67hO2aNinZbmcWSnxEVPWYEA3Y0xRjvEl CFeQ== X-Gm-Message-State: ACrzQf26sqkeQNX6DZMu11Qa32fjQliMIHCY6JVkl0/6iadhTTbPTtJC XjQxgbOWyqAVLLNLITP3RCfSFF53jzhxspyWhtLcL/lt/WsIjU2W/OqBjxnjp5KV4hczCfuFn9S z+AHXwHj5JPu3ShZsTg== X-Received: by 2002:a37:ad0a:0:b0:6ce:1769:6f51 with SMTP id f10-20020a37ad0a000000b006ce17696f51mr15006086qkm.522.1664209579115; Mon, 26 Sep 2022 09:26:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6BnXfWEEXe8JTwejYyB7UQtDcKFrghc1uhIdGpyMHkZqfgS0zUzwDMMFXAaZRCcOhFrbcpGQ== X-Received: by 2002:a37:ad0a:0:b0:6ce:1769:6f51 with SMTP id f10-20020a37ad0a000000b006ce17696f51mr15006073qkm.522.1664209578919; Mon, 26 Sep 2022 09:26:18 -0700 (PDT) Received: from redhat.com (2603-7000-9500-2e39-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:2e39::1db4]) by smtp.gmail.com with ESMTPSA id bq8-20020a05620a468800b006b9bf03d9c6sm11774581qkb.104.2022.09.26.09.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 09:26:18 -0700 (PDT) Date: Mon, 26 Sep 2022 12:26:16 -0400 From: Marek Polacek To: Jonathan Wakely Cc: GCC Patches , Jason Merrill Subject: Re: [PATCH] c++: Instantiate less when evaluating __is_convertible Message-ID: References: <20220926152258.20921-1-polacek@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Sep 26, 2022 at 05:02:36PM +0100, Jonathan Wakely wrote: > On Mon, 26 Sept 2022 at 16:23, Marek Polacek wrote: > > > > Jon reported that evaluating __is_convertible in this test leads to > > instantiating char_traits::eq, which is invalid (because we > > are trying to call a member function on a char) > > N.B. in the original code wasn't trying to do something dumb like call > a member function on a char, but it was using basic_string_view > where X is a class type without an operator== and so > char_traits::eq was invalid. I changed it to just use > basic_string_view and changed char_traits::eq to do something > different, that was invalid for char. Ack. > I can provide a less silly test case if you like, but I don't think it > matters for the purposes of the testsuite. I think no need to, I'm going to use Patrick's short test. Thanks, Marek