public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Julian Brown <julian@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, tobias@codesourcery.com
Subject: Re: [PATCH] OpenACC: Fix struct-component-kind-1.c test
Date: Sat, 1 Oct 2022 10:35:29 +0200	[thread overview]
Message-ID: <Yzf70amZHwg4MEHY@tucnak> (raw)
In-Reply-To: <20221001075659.63410-1-julian@codesourcery.com>

On Sat, Oct 01, 2022 at 12:56:59AM -0700, Julian Brown wrote:
> This patch is a minimal fix for the recently-added
> struct-component-kind-1.c test (which is currently failing to emit one
> of the errors it expects in scan output). This fragment was erroneously omitted from the second version of the patch posted previously:
> 
>   https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602504.html
> 
> Re-tested with offloading to NVPTX. OK?
> 
> Thanks,
> 
> Julian
> 
> 2022-10-01  Julian Brown  <julian@codesourcery.com>
> 
> gcc/
> 	* gimplify.cc (omp_group_base): Fix IF_PRESENT (no_create)
> 	handling.

Ok.

> ---
>  gcc/gimplify.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
> index 90606088128..9e0e3429958 100644
> --- a/gcc/gimplify.cc
> +++ b/gcc/gimplify.cc
> @@ -9245,6 +9245,7 @@ omp_group_base (omp_mapping_group *grp, unsigned int *chained,
>      case GOMP_MAP_RELEASE:
>      case GOMP_MAP_DELETE:
>      case GOMP_MAP_FORCE_ALLOC:
> +    case GOMP_MAP_IF_PRESENT:
>        if (node == grp->grp_end)
>  	return node;
>  
> @@ -9323,7 +9324,6 @@ omp_group_base (omp_mapping_group *grp, unsigned int *chained,
>      case GOMP_MAP_FORCE_DEVICEPTR:
>      case GOMP_MAP_DEVICE_RESIDENT:
>      case GOMP_MAP_LINK:
> -    case GOMP_MAP_IF_PRESENT:
>      case GOMP_MAP_FIRSTPRIVATE:
>      case GOMP_MAP_FIRSTPRIVATE_INT:
>      case GOMP_MAP_USE_DEVICE_PTR:
> -- 
> 2.29.2

	Jakub


      reply	other threads:[~2022-10-01  8:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  7:56 Julian Brown
2022-10-01  8:35 ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzf70amZHwg4MEHY@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=julian@codesourcery.com \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).