From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id DDDEC3858C20 for ; Sat, 1 Oct 2022 11:35:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDDEC3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42c.google.com with SMTP id s14so10491926wro.0 for ; Sat, 01 Oct 2022 04:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Wz4RRJY0pM1puy7PZmICr4TLt1AVOsJhnHvwVxqEGlE=; b=ZphsxuD8lHIQHZ/fKsTPvEWxQnO3Qrkv8GkN0g5jk+nULFzLG9mKHZN2BXZHTKukVr MXUZ2+c3XwFoJPWfXCm3iRsOIz0mJeVnPm4eOpkzeeMPU0ByBYQxtXsy3XtFIiZ97MkK TAac6gEW2xBGZtx5CNvd1zvHHgU1ameGIaGf4eg/PO6FjpE7CQAlehV60vElgM4W8J8i huL6wP/yunllXQE42rA6pQTvlvAdpm3ZyZkc9adSSHp/HtjbMo+CdBVY8k7lLM8SZYIZ LVfsaOy2gWVgL7PX8Yfp8Pclw8NBMy6Bcv3koa2gePsb9045rOLsL6VY8ZuIxYTdpGNB 4pSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Wz4RRJY0pM1puy7PZmICr4TLt1AVOsJhnHvwVxqEGlE=; b=ZV4uEDhU0GfRi/4rhqnC0ftIvK/7bMZv4/DdRNnCU3UToGEnY/9BHGxUYZ7xDAqSp5 k2i8/fhbojnNPtSCu2+b/fwz3M83fZ19mE10gw6gCvCqEg8sPrwl8WvQ7KY66VCLQy9b nbEPEHA8jRL2MJlx5ghP6tXGnp7J/74J+WZLzXLJg5aSICkhj8cPUKcoq2r0lhspGVpr ipoJhZUX8dBkRb6byuMPfoA9k8fLvz7zw8EKpM+Yo1hLNaNQz0bZGsKpUbb4mYa4zQgK fC2LUVVBeFg/TyQvzPyH306cOIsgXBj0f08jXnJbBZXU/3ynIvDKTy6MCUDjPRHPiJhJ rOpQ== X-Gm-Message-State: ACrzQf0V2LUK8+n842MS6SMoMVdgx3+m513vCZzWht3l4k1YczG6tR1C eq1yLYihPUmoQ7YzeSf4MZFmjh/saqM= X-Google-Smtp-Source: AMsMyM64ctalizvFuDs0j3MfeBVVnHO15wJ2mtaQ322AH2hi2ofx1qwPGU/2g5WATQNwR2fqsGHjrw== X-Received: by 2002:a5d:47a1:0:b0:22a:2979:4899 with SMTP id 1-20020a5d47a1000000b0022a29794899mr7961356wrb.349.1664624157165; Sat, 01 Oct 2022 04:35:57 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::dee:c001]) by smtp.gmail.com with ESMTPSA id w7-20020adfde87000000b0022afedf3c87sm4780898wrl.105.2022.10.01.04.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Oct 2022 04:35:56 -0700 (PDT) Date: Sat, 1 Oct 2022 11:35:55 +0000 From: Stafford Horne To: gcc-patches@gcc.gnu.org Cc: openrisc@lists.librecores.org, Yann Morin , buildroot@buildroot.org Subject: Re: [PATCH] or1k: Only define TARGET_HAVE_TLS when HAVE_AS_TLS Message-ID: References: <20220929145740.4846-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929145740.4846-1-shorne@gmail.com> X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 29, 2022 at 03:57:40PM +0100, Stafford Horne wrote: > This was found when testing buildroot with linuxthreads enabled. In > this case, the build passes --disable-tls to the toolchain during > configuration. After building the OpenRISC toolchain it was still > generating TLS code sequences and causing linker failures such as: > > ..../or1k-buildroot-linux-uclibc-gcc -o gpsd-3.24/gpsctl .... -lusb-1.0 -lm -lrt -lnsl > ..../ld: ..../sysroot/usr/lib/libusb-1.0.so: undefined reference to `__tls_get_addr' > > This patch fixes this by disabling tls for the OpenRISC target when requested > via --disable-tls. > > Tested-by: Yann E. MORIN > > gcc/ChangeLog: > > * config/or1k/or1k.cc (TARGET_HAVE_TLS): Only define if > HAVE_AS_TLS is defined. I have pushed this upstream now. Adding buildroot patches should be easy to do now. -Stafford