From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9EDC53858D32 for ; Mon, 13 Mar 2023 08:07:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EDC53858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678694823; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=IZqUq2l81OHwe9kIgJvBCeef7AddKUeQnXpuMgdpVUg=; b=GvhOhEOELAB9L5yioXrO2bTCDs2mnHk6EK++rnAhfe828bqJplze8oXIQsD4zIJRi4uyMy W1kkILjidYZu3j+L4T18JirHRXeM6oP7du2RdKLVi8L35+XrSf8qlCRpTlQ2ZKmjhnyFRV /UhOlcUEgOEKnH+GOMHtgbjlNFZZaJk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-616-FhdOhr8NNvCzPmCquz7kzg-1; Mon, 13 Mar 2023 04:06:59 -0400 X-MC-Unique: FhdOhr8NNvCzPmCquz7kzg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D6251185A7A4; Mon, 13 Mar 2023 08:06:58 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97633400F5D; Mon, 13 Mar 2023 08:06:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32D86uBe966688 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 13 Mar 2023 09:06:56 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32D86tXq966687; Mon, 13 Mar 2023 09:06:55 +0100 Date: Mon, 13 Mar 2023 09:06:54 +0100 From: Jakub Jelinek To: Aldy Hernandez Cc: Richard Biener , gcc-patches@gcc.gnu.org, Andrew MacLeod Subject: Re: [PATCH] range-op-float: Fix up -ffinite-math-only range extension and don't extend into infinities [PR109008] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Mar 13, 2023 at 08:59:15AM +0100, Aldy Hernandez wrote: > > Yes, sure - I just noticed that we're forced to use high-level API for > > something that's quite low-level and should be internal (a range > > "breaking" internal consistency checks). > > Yeah, let's fix the API. No sense hacking around things if what we need is > to tweak the design. > > I don't like hacking around things. It always comes back to bite me ;-). Sure. The current state is that I think the actual bugs are fixed except for the !MODE_HAS_INFINITIES case which people rarely use, so fixing up the API can wait even to next release. For !MODE_HAS_INFINITIES, I wonder if the best fix wouldn't be to change set and a few other spots, so that if the boundaries are real_min_representable/real_max_representable, we widen them to -inf and inf and change frange_val_min/max to also be dconstninf/dconstinf for !MODE_HAS_INFINITIES, because the min/max for that case (probably) really work as infinities. Whenever we actually round that value to mode, it will become real_min_representable/real_max_representable again. But that can also wait a week. Jakub