From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1DBF63858D37 for ; Thu, 2 Mar 2023 23:52:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DBF63858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677801153; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=d1KSRe2VeuoRZ+pg07oKKYGQ4Nwnqb77/FjVTMrrbQI=; b=OYva1HPKWOirzQzgF4/I+lLAWLirMpVmbP+VCTeyuTubdYO/R8oWVNO7ruewYDAZSac+jt QZB+mXb4qyKAL8Fvw4Qj1RTny47KLGmp0/AsbTV6+an1zmEW73VAfG1rlgXtTj/9dNsXMl oyLJblSwMhHUtF2btZtVN36eALP+VNc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-164-uyHtlJs2N4me2Wxensga7Q-1; Thu, 02 Mar 2023 18:52:30 -0500 X-MC-Unique: uyHtlJs2N4me2Wxensga7Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D46C101A521; Thu, 2 Mar 2023 23:52:30 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AB6D40C6EC4; Thu, 2 Mar 2023 23:52:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 322NqRgl1817428 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 3 Mar 2023 00:52:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 322NqQ1i1817427; Fri, 3 Mar 2023 00:52:26 +0100 Date: Fri, 3 Mar 2023 00:52:26 +0100 From: Jakub Jelinek To: Jonathan Yong <10walls@gmail.com> Cc: Jonathan Yong via Gcc-patches , richard.sandiford@arm.com Subject: [committed] testsuite: Fix up memchr-3.c test [PR108991] Message-ID: Reply-To: Jakub Jelinek References: <51b54f05-f6d6-fbb1-9f5a-987e47264a1d@gmail.com> MIME-Version: 1.0 In-Reply-To: <51b54f05-f6d6-fbb1-9f5a-987e47264a1d@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 02, 2023 at 01:43:30PM +0000, Jonathan Yong via Gcc-patches wrote: > On 3/2/23 10:46, Richard Sandiford wrote: > > > diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c > > > index c38d9cf3349..af1b26ef3ae 100644 > > > --- a/gcc/testsuite/gcc.dg/memchr-3.c > > > +++ b/gcc/testsuite/gcc.dg/memchr-3.c > > > @@ -6,7 +6,7 @@ > > > typedef __INT8_TYPE__ int8_t; > > > typedef __INT32_TYPE__ int32_t; > > > -extern void* memchr (const void*, int, long); > > > +extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */ > > > struct SX > > > { > > > > OK, thanks. > > Thanks, pushed to master branch. The newly added dg-warning directive was missing the comment argument, so the target selector was treated as comment and the warning was expected on all targets when it should be expected only on llp64 targets. Tested on x86_64-linux -m32/-m64, committed to trunk as obvious: 2023-03-03 Jakub Jelinek PR testsuite/108991 * gcc.dg/memchr-3.c: Add missing comment argument to dg-warning before target selector. --- gcc/testsuite/gcc.dg/memchr-3.c.jj 2023-03-02 19:09:45.466594110 +0100 +++ gcc/testsuite/gcc.dg/memchr-3.c 2023-03-03 00:48:04.368348282 +0100 @@ -6,7 +6,7 @@ typedef __INT8_TYPE__ int8_t; typedef __INT32_TYPE__ int32_t; -extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" { target llp64 } } */ +extern void* memchr (const void*, int, long); /* { dg-warning "-Wbuiltin-declaration-mismatch" "" { target llp64 } } */ struct SX { Jakub