From: Jakub Jelinek <jakub@redhat.com>
To: Robin Dapp <rdapp@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Andreas Krebbel <krebbel@linux.ibm.com>
Subject: Re: [committed] testsuite: Fix up syntax errors in scan-tree-dump-times target selectors
Date: Tue, 7 Mar 2023 09:48:58 +0100 [thread overview]
Message-ID: <ZAb6etlmwuW8MDnI@tucnak> (raw)
In-Reply-To: <fe1f7d84-aa4d-80ef-dad9-1cb514a509ba@linux.ibm.com>
On Mon, Mar 06, 2023 at 11:27:16AM +0100, Robin Dapp wrote:
> > This broke the tests, I'm seeing syntax errors:
> > ERROR: gcc.dg/vect/slp-3.c -flto -ffat-lto-objects: error executing dg-final: syntax error in target selector "target ! vect_partial_vectors || vect32 || s390_vx"
> > ERROR: gcc.dg/vect/slp-3.c: error executing dg-final: syntax error in target selector "target ! vect_partial_vectors || vect32 || s390_vx"
> > ERROR: gcc.dg/vect/slp-multitypes-11.c -flto -ffat-lto-objects: error executing dg-final: syntax error in target selector "target vect_unpack && vect_partial_vectors_usage_1 && ! s390_vx"
> > ERROR: gcc.dg/vect/slp-multitypes-11.c: error executing dg-final: syntax error in target selector "target vect_unpack && vect_partial_vectors_usage_1 && ! s390_vx"
>
> it appears that we are still missing some braces:
>
> diff --git a/gcc/testsuite/gcc.dg/vect/slp-3.c b/gcc/testsuite/gcc.dg/vect/slp-3.c
> index a0c6a72995bb..760b3fa35a2a 100644
> --- a/gcc/testsuite/gcc.dg/vect/slp-3.c
> +++ b/gcc/testsuite/gcc.dg/vect/slp-3.c
> @@ -144,4 +144,4 @@ int main (void)
> /* { dg-final { scan-tree-dump-times "vectorized 3 loops" 1 "vect" { target { { ! { vect_partial_vectors || vect32 } } || s390_vx } } } } */
> /* { dg-final { scan-tree-dump-times "vectorized 4 loops" 1 "vect" { target { { vect_partial_vectors || vect32 } && { ! s390_vx } } } } } */
> /* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 3 "vect" { target { { ! { vect_partial_vectors || vect32 } } || s390_vx } } } } */
> -/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "vect" { target { vect_partial_vectors || vect32 } && { ! s390_vx } } } } */
> +/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 4 "vect" { target { { vect_partial_vectors || vect32 } && { ! s390_vx } } } } } */
>
> Would you mind double-checking and committing if it's OK?
I'm not a TCL expert, I certainly can't reproduce any ERROR with this
anymore on any target, though I think your change is ok.
So please just check it in yourself, you've my ack for it.
> I keep making mistakes with the dejagnu syntax. I suppose there is no better way
> to test the selector (and regex) syntax than just running an individual test case?
I'll defer that to TCL experts.
Jakub
prev parent reply other threads:[~2023-03-07 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 18:23 [PATCH] testsuite: Do not expect partial vectorization for s390 Robin Dapp
2023-03-03 11:09 ` Richard Biener
2023-03-04 9:46 ` [committed] testsuite: Fix up syntax errors in scan-tree-dump-times target selectors Jakub Jelinek
2023-03-05 18:13 ` [committed] testsuite: Fix up syntax error in scan-tree-dump-times target selector Jakub Jelinek
2023-03-06 10:27 ` [committed] testsuite: Fix up syntax errors in scan-tree-dump-times target selectors Robin Dapp
2023-03-07 8:48 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAb6etlmwuW8MDnI@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.ibm.com \
--cc=rdapp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).