From: Jakub Jelinek <jakub@redhat.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>,
Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [PATCH] [RFC] RAII auto_mpfr and autp_mpz
Date: Tue, 7 Mar 2023 20:03:44 +0100 [thread overview]
Message-ID: <ZAeKkDknTqng1MDC@tucnak> (raw)
In-Reply-To: <20230307195103.28436b26@nbbrfq>
On Tue, Mar 07, 2023 at 07:51:03PM +0100, Bernhard Reutner-Fischer wrote:
> While it's a nice idea, there have been resentments towards (visible)
> C++ in the fortran frontend and especially the library, i think.
I thought libgfortran is written in C and Fortran and doesn't use gmp/mpfr,
so this doesn't apply to it (ok, intrinsics/trigd.inc uses mpfr_*
names macros if in library which do something different).
As for the FE, we don't need to change all places with manual
allocation/deallocation for those, though changing most of them
will help with maintainability as one doesn't have to care about leaks.
I only see 2 mpfr_init2 calls in Fortran FE though, so pressumably
everything else could use visually C like auto_mpfr var;
instead of mpfr_t var + mpfr_init + mpfr_clear.
Jakub
next prev parent reply other threads:[~2023-03-07 19:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 10:11 Richard Biener
2023-03-06 10:44 ` Jonathan Wakely
2023-03-06 11:01 ` Richard Biener
2023-03-06 11:03 ` Jonathan Wakely
2023-03-06 11:10 ` Jakub Jelinek
2023-03-06 11:29 ` Richard Biener
2023-03-07 18:51 ` Bernhard Reutner-Fischer
2023-03-07 19:03 ` Jakub Jelinek [this message]
2023-04-02 15:05 ` [PATCH 0/3] Fix mpfr and mpz memory leaks Bernhard Reutner-Fischer
2023-04-02 15:05 ` [PATCH 1/3] go: Fix memory leak in Integer_expression Bernhard Reutner-Fischer
2023-04-02 15:05 ` [PATCH 2/3] rust: Fix memory leak in compile_{integer,float}_literal Bernhard Reutner-Fischer
2023-04-02 15:05 ` [PATCH 3/3] Fortran: Fix mpz and mpfr memory leaks Bernhard Reutner-Fischer
2023-04-03 19:50 ` Harald Anlauf
2023-04-03 19:50 ` Harald Anlauf
2023-04-03 21:42 ` Bernhard Reutner-Fischer
2023-04-17 19:47 ` ping " Bernhard Reutner-Fischer
2023-04-17 22:18 ` Steve Kargl
2023-05-08 6:00 ` Bernhard Reutner-Fischer
2023-03-07 19:15 ` [PATCH] [RFC] RAII auto_mpfr and autp_mpz Alexander Monakov
2023-03-07 21:35 ` Jonathan Wakely
2023-03-07 21:51 ` Alexander Monakov
2023-03-07 21:54 ` Jonathan Wakely
2023-03-07 21:59 ` Marek Polacek
2023-03-08 7:25 ` Richard Biener
2023-03-08 10:13 ` Jonathan Wakely
2023-03-08 10:33 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAeKkDknTqng1MDC@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=rep.dot.nop@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).