From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B257E3858D20 for ; Thu, 9 Mar 2023 18:13:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B257E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678385589; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=WwARMG681ii4phpq9aK8IYZIwsx3kroMK7lskyYAbpA=; b=BERMkfh5NlBggWNBg2T75iQcjWRHko8EKaYBSM8JiwxRsXoqYJLmU0jsY37NHIY5Ak+T2k c3syQc9vcKTKLbG++pjl98mXxsNd+IrQvC7vr51KlBxWPfHWvwwtFx9zH3R1AWIVShJmxX v85Tm0e9IJZLQxagjF1yrBzM8QNAeH0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-ioWPdiz2PK2dYlH-LJ1X5A-1; Thu, 09 Mar 2023 13:13:06 -0500 X-MC-Unique: ioWPdiz2PK2dYlH-LJ1X5A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCC08802D2E; Thu, 9 Mar 2023 18:13:05 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90CCC2026D4B; Thu, 9 Mar 2023 18:13:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 329ID2rh2008374 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 9 Mar 2023 19:13:03 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 329ID23B2007594; Thu, 9 Mar 2023 19:13:02 +0100 Date: Thu, 9 Mar 2023 19:13:01 +0100 From: Jakub Jelinek To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCHv2] Fix PR 108980: note without warning due to array bounds check Message-ID: Reply-To: Jakub Jelinek References: <20230309180320.2899452-1-apinski@marvell.com> MIME-Version: 1.0 In-Reply-To: <20230309180320.2899452-1-apinski@marvell.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 09, 2023 at 10:03:20AM -0800, Andrew Pinski via Gcc-patches wrote: > The problem here is after r13-4748-g2a27ae32fabf85, in some > cases we were calling inform without a corresponding warning. > This changes the logic such that we only cause that to happen > if there was a warning happened before hand. > > Changes since > * v1: Fix formating and dump message as suggested by Jakub. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > gcc/ChangeLog: > > PR tree-optimization/108980 > * gimple-array-bounds.cc (array_bounds_checker::check_array_ref): > Reorgnize the call to warning for not strict flexible arrays > to be before the check of warned. > --- > gcc/gimple-array-bounds.cc | 41 ++++++++++++++++++++++++-------------- > 1 file changed, 26 insertions(+), 15 deletions(-) It would be nice to have a testcase with dg-bogus for the messages, but seems we don't have one in the PR, so ok for trunk. Jakub