From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Yong <10walls@gmail.com>
Cc: gcc-patches@gcc.gnu.org, NightStrike <nightstrike@gmail.com>,
Stromeko@nexgo.de
Subject: Patch ping: [PATCH] cygwin: Don't try to support multilibs [PR107998]
Date: Fri, 10 Mar 2023 10:37:09 +0100 [thread overview]
Message-ID: <ZAr6RdzQMJ5uAByh@tucnak> (raw)
In-Reply-To: <ZAJAH+LYtAAzJQH9@tucnak>
Hi!
I'd like to ping this patch (as I wrote a week ago, NightStrike has tested
it):
On Fri, Mar 03, 2023 at 07:44:47PM +0100, Jakub Jelinek via Gcc-patches wrote:
> > > 2023-02-22 Jakub Jelinek <jakub@redhat.com>
> > >
> > > PR target/107998
> > > * config.gcc (x86_64-*-cygwin*): Don't add i386/t-cygwin-w64 into
> > > $tmake_file.
> > > * config/i386/t-cygwin-w64: Remove.
> > >
> > > --- gcc/config.gcc.jj 2023-02-18 12:38:30.803025062 +0100
> > > +++ gcc/config.gcc 2023-02-21 17:07:12.143164563 +0100
> > > @@ -2105,7 +2105,7 @@ x86_64-*-cygwin*)
> > > need_64bit_isa=yes
> > > tm_file="${tm_file} i386/unix.h i386/bsd.h i386/gas.h i386/cygming.h i386/cygwin.h i386/cygwin-w64.h i386/cygwin-stdint.h"
> > > xm_file=i386/xm-cygwin.h
> > > - tmake_file="${tmake_file} i386/t-cygming t-slibgcc i386/t-cygwin-w64"
> > > + tmake_file="${tmake_file} i386/t-cygming t-slibgcc"
> > > target_gtfiles="$target_gtfiles \$(srcdir)/config/i386/winnt.cc"
> > > extra_options="${extra_options} i386/cygming.opt i386/cygwin.opt"
> > > extra_objs="${extra_objs} winnt.o winnt-stubs.o"
> > > --- gcc/config/i386/t-cygwin-w64.jj 2020-01-12 11:54:36.333414616 +0100
> > > +++ gcc/config/i386/t-cygwin-w64 2023-02-21 17:06:44.121572616 +0100
> > > @@ -1,3 +0,0 @@
> > > -MULTILIB_OPTIONS = m64/m32
> > > -MULTILIB_DIRNAMES = 64
> > > -MULTILIB_OSDIRNAMES = ../lib ../lib32
> >
> > Achim, mind looking at this?
> > Resending due to mail client problems, hopefully not a duplicate.
>
> NightStrike on IRC said he has tested the patch and it worked fine.
>
> Is the patch ok for trunk then?
Jakub
next prev parent reply other threads:[~2023-03-10 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 9:25 Jakub Jelinek
2023-02-22 13:00 ` Jonathan Yong
2023-02-22 13:02 ` Jonathan Yong
2023-03-03 18:44 ` Jakub Jelinek
2023-03-10 9:37 ` Jakub Jelinek [this message]
2023-03-10 10:19 ` Patch ping: " Jonathan Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAr6RdzQMJ5uAByh@tucnak \
--to=jakub@redhat.com \
--cc=10walls@gmail.com \
--cc=Stromeko@nexgo.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=nightstrike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).