public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, manu@gcc.gnu.org
Subject: Re: [PATCH 2/2] tree-optimization/109123 - run -Wuse-afer-free only early
Date: Wed, 15 Mar 2023 15:49:03 +0100	[thread overview]
Message-ID: <ZBHa348j08gRqgHT@tucnak> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2303151432290.18795@jbgna.fhfr.qr>

On Wed, Mar 15, 2023 at 02:39:43PM +0000, Richard Biener via Gcc-patches wrote:
> I've tested and most of the -Wuse-after-free testcases work with -Og
> before and after the change (unfortunately adding -Og via RUNTESTFLAGS
> doesn't work since explicit -O2 in the testcases overrides that).
> 
> We also do not have much test coverage here and I'm hesitant to change
> this now.
> 
> That said, with the adjusted first patch and the split out fix for
> g++.dg/warn/Wuse-after-free3.C the following is what I propose now.
> There's extra adjustments in gcc.dg/Wuse-after-free-2.c as we now
> mention the pointer that is used.
> 
> I do think not running these kind of diagnostics very late, at least
> a diagnostic like this that's prone to false positives due to
> code motion.  But I'm also happy to leave the state of affairs as-is
> for GCC 13, but I don't promise to be able to pick up things during
> next stage1 again.
> 
> Re-re-re-bootstrap & regtest running on x86_64-unknown-linux-gnu.
> 
> Unless I get clear opinions I'm going to throw some dice whether
> to apply 1/2 and will "defer" this one.

Let's go with both patches then, if somebody files false negative issues
for this warning later on, we can amend it further later.

	Jakub


  reply	other threads:[~2023-03-15 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230315104924.7F449385828D@sourceware.org>
2023-03-15 11:26 ` Jakub Jelinek
2023-03-15 11:54   ` Richard Biener
2023-03-15 14:39     ` Richard Biener
2023-03-15 14:49       ` Jakub Jelinek [this message]
2023-03-15 10:49 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBHa348j08gRqgHT@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=manu@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).