From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 216023858D3C for ; Thu, 16 Mar 2023 14:27:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 216023858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678976878; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=I46AU/zBNG9JxfrcPbPnX8HxfYNS079ZlXboCALPul8=; b=Y4dJLRnpf7zO1/EqgHdECYRe+cMl0f4vDC4xB4mfCWYCaReeNrFBs/Z5HnUm8AFyf8Wa+r cptkVgIJpp2uBAoDU1o7OILhprSzD84I7hNorWtvHsR1H0JD/1mKULcC1zWgIbWtz1hlgI +RkcTaccaeKBlaLlobWUJuWjwcTza80= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-4gGEllcyNhKNpp9bs8tbGQ-1; Thu, 16 Mar 2023 10:27:57 -0400 X-MC-Unique: 4gGEllcyNhKNpp9bs8tbGQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB1A1185A7A4; Thu, 16 Mar 2023 14:27:56 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88051492B02; Thu, 16 Mar 2023 14:27:56 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32GERrWS2893223 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 16 Mar 2023 15:27:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32GERqQX2893222; Thu, 16 Mar 2023 15:27:52 +0100 Date: Thu, 16 Mar 2023 15:27:51 +0100 From: Jakub Jelinek To: Richard Biener Cc: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/106912 - IPA profile and pure/const Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 16, 2023 at 02:11:01PM +0000, Richard Biener wrote: > > Let's wait for Honzas opinion. > > The following is what I profile-bootstrapped and tested on > x86_64-unknown-linux-gnu. > > Richard. > > >From d438a0d84cafced85c90204cba81de0f60ad0073 Mon Sep 17 00:00:00 2001 > From: Richard Biener > Date: Thu, 16 Mar 2023 13:51:19 +0100 > Subject: [PATCH] tree-optimization/106912 - clear const attribute from fntype > To: gcc-patches@gcc.gnu.org > > The following makes sure that after clearing pure/const from > instrumented function declarations we are adjusting call statements > fntype as well to handle indirect calls and because gimple_call_flags > looks at both decl and fntype. > > Like the pure/const flag clearing on decls we refrain from touching > calls to known functions that do not have a body in the current TU. > > PR tree-optimization/106912 > * tree-profile.cc (tree_profiling): Update stmts only when > profiling or testing coverage. Make sure to update calls > fntype, stripping 'const' there. > > * gcc.dg/profile-generate-4.c: New testcase. > + if (fntype && TYPE_READONLY (fntype)) > + gimple_call_set_fntype > + (call, build_qualified_type (fntype, (TYPE_QUALS (fntype) > + & ~TYPE_QUAL_CONST))); I think if (fntype && TYPE_READONLY (fntype)) { int quals = TYPE_QUALS (fntype) & ~TYPE_QUAL_CONST; fntype = build_qualified_type (fntype, quals); gimple_call_set_fntype (call, fntype); } would be nicer formatting for it. Anyway, let's wait for Honza, LGTM. > + > + /* Update virtual operands of calls to no longer const/pure > + functions. */ > + update_stmt (call); > + } > + } > > /* re-merge split blocks. */ > cleanup_tree_cfg (); Jakub